On Monday, September 11, 2017, Huji Lee <huji.huji(a)gmail.com> wrote:
After having worked with gerrit for years, I have
finally decided to be a
good citizen and instead of submitting a patch, finding out that Gerritbot
has found issues with it, and re-submitting the patch (and thereby,
generating very long chains of patch sets), I should test my code using
phpcs and phpunit before submitting it :)
The problem is phpunit gives me a lot of errors all the time (see
https://phabricator.wikimedia.org/T175397 ). So I thought I should ask
more
experienced developers: how do you test your code
before submitting the
patch?
Thanks,
Huji
I find phpunit painful to run locally the full thing. There seems to be
plenty false positives (presumably due to my custom LocalSettings.php) and
it takes forever.
Usually what ill do is run a specific test file if im editing stuff around
that area. This doesnt work forall unit tests but is mostly good enough.
E.g.
cd tests/phpunit
php phpunit.php includes/foo/SomethingTest.php
If im editing the parser i usually use the old parser test harness to run
the tests.
And honestly i usually only do that if im doing something riskly. Mostly i
rely on jenkins.
--
brian