On 10/04/12 22:36, Ildefons Stułbia wrote:

Hi.

I am writing a tool for analyzing vandalism and I have difficulties with revdeleted revisions, because they are not available using API.

I have pushed a chunk of code for review https://gerrit.wikimedia.org/r/#change,4658 to get some feedback. More information is available in the commit message. I would like to know if this is correct way before I start changing next modules.

Regards, Ildefons Stułbia

Seems the right approach. A couple of notes: this email should have been directed to wikitech-l, mediawiki-l is more general, not dealing with development decisions (so it could have been skipped). I don't like the parameter name "rvunhide", as you're not changing the hidden status of the revisions itself. I'd prefer something like rvshowhidden=user|comment|content

Thanks for your work Best regards