REL 1_31 introduced 'mwdebug' option in Maintenance.php (in the code it mentions that --debug was taken by some script). The code incorrectly adds the option via addOption() by setting the 4th argument to true (takes an argument). This should be false. At least, the rest of the code is clear, and so is the intent: there is no option to be taken.
https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_31/maintenanc...
Hi Otheus,
On Mon, 2019-09-16 at 21:58 +0200, Otheus wrote:
REL 1_31 introduced 'mwdebug' option in Maintenance.php (in the code it mentions that --debug was taken by some script). The code incorrectly adds the option via addOption() by setting the 4th argument to true (takes an argument). This should be false. At least, the rest of the code is clear, and so is the intent: there is no option to be taken.
https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_31/maintenanc...
Thanks for finding this. Can you please create a bug report? https://www.mediawiki.org/wiki/How_to_report_a_bug
Thanks! andre
Too much trouble. How do I submit a patch or diff or whatever? Is phabircator the primary git repo these days? If so, how do i male a pull request?
On Tue, Sep 17, 2019, 03:13 Andre Klapper aklapper@wikimedia.org wrote:
Hi Otheus,
On Mon, 2019-09-16 at 21:58 +0200, Otheus wrote:
REL 1_31 introduced 'mwdebug' option in Maintenance.php (in the code it mentions that --debug was taken by some script). The code incorrectly
adds
the option via addOption() by setting the 4th argument to true (takes an argument). This should be false. At least, the rest of the code is clear, and so is the intent: there is no option to be taken.
https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_31/maintenanc...
Thanks for finding this. Can you please create a bug report? https://www.mediawiki.org/wiki/How_to_report_a_bug
Thanks! andre -- Andre Klapper (he/him) | Bugwrangler / Developer Advocate https://blogs.gnome.org/aklapper/
MediaWiki-l mailing list To unsubscribe, go to: https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
On Tue, 2019-09-17 at 13:15 +0200, Otheus wrote:
Too much trouble.
Not really.
How do I submit a patch or diff or whatever? Is phabircator the primary git repo these days?
It is not. Gerrit is used for code review.
If so, how do i male a pull request?
See https://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
Thanks, andre
I filed a bug, since no one else did :)
https://phabricator.wikimedia.org/T233257
Thanks, Bartosz.
On Wed, Sep 18, 2019 at 9:57 PM Bartosz Dziewoński matma.rex@gmail.com wrote:
I filed a bug, since no one else did :)
https://phabricator.wikimedia.org/T233257
-- Bartosz Dziewoński
MediaWiki-l mailing list To unsubscribe, go to: https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
mediawiki-l@lists.wikimedia.org