Several people expressed interest in this hack. Since my attachment got stripped, I've put the diff below.
This change probably doesn't make sense as an RFE because it is useful only on intranets AFAIK...
Parser.php (1.3.8) diff:
1037,1044d1036 < # JBA inserted code here < # Replace P4:// with stuff to point at P4WEB. < # Allows links of the form P4://depot/the/file < # Replace p4machine:8081 w/ your p4web mach:port < $text = preg_replace( < "#P4://([^ ]]+)(\s|]|$)#U", < 'http://p4machine:8081//$%7B1%7D?ac=64$%7B2%7D', < $text); < # JBA end of code insertion
__________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo
On Dec 2, 2004, at 10:42 AM, John Andrews wrote:
1037,1044d1036 < # JBA inserted code here < # Replace P4:// with stuff to point at P4WEB. < # Allows links of the form P4://depot/the/file < # Replace p4machine:8081 w/ your p4web mach:port < $text = preg_replace( < "#P4://([^ ]]+)(\s|]|$)#U", < 'http://p4machine:8081//$%7B1%7D?ac=64$%7B2%7D', < $text); < # JBA end of code insertion
This is the kind of thing extensions would be great for... :) Having to hack up Parser.php is a maintenance burden (since it makes upgrades more difficult). Are we still missing an appropriate hook point for this kind of thing?
-- brion vibber (brion @ pobox.com)
mediawiki-l@lists.wikimedia.org