I've put up an rc1 release with the following bit added to the RELEASE-NOTES-1.20 file:
=== Known issues in 1.20.0 === These are issues that we're targeting to be fixed in a later release in the 1.20 series. Issues may be added or removed from this list as we see fit. For now, it is comprised of those bugs on the 1.20.0 milestone in Bugzilla.
* (bug 27202): API: Add timestamp sort to list=allimages * (bug 35894): Reports of secret key generation "hanging" on windows * (bug 37209): LinkCache doesn't currently know about this title * (bug 37714): [Regression] Incomplete log entries * (bug 38334): PHP Notice: Undefined index: href in /www/w/skins/Vector.php on line 416 * (bug 39268): [Regression] Toolbar inserts in main textarea only (instead of the focussed textarea) * (bug 40598): [Regression] jquery.localize tests are failing in IE6-8 * (bug 40632): Kill $wgCleanupPresentationalAttributes from MediaWiki core * (bug 40641): Clicking "others" in Special:Version asks to download a file * (bug 40780): searchsuggest-containing line ("containing...") doesn't include the entered text * (bug 40939): [Regression] InfoAction: Call to a member function getUserText() on a non-object
Full release notes: http://mah.everybody.org/mediawiki/1.20/RELEASE-NOTES-1.20.txt
********************************************************************** Download: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc1.tar.gz
GPG signatures: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc1.tar.gz.sig
Public keys: http://mah.everybody.org/contact-info http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7956EE477F901A30
On 14/10/12 01:14, Mark A. Hershberger wrote:
I've put up an rc1 release with the following bit added to the RELEASE-NOTES-1.20 file:
=== Known issues in 1.20.0 === These are issues that we're targeting to be fixed in a later release in the 1.20 series. Issues may be added or removed from this list as we see fit. For now, it is comprised of those bugs on the 1.20.0 milestone in Bugzilla.
As these look a bit like "shipping with ugly bugs", I have done a quick check of their severity:
- (bug 27202): API: Add timestamp sort to list=allimages
Enhancement request
- (bug 35894): Reports of secret key generation "hanging" on windows
I think this only affects non-latest php. Maybe show a warning in the installer for Windows and the affected versions?
- (bug 37209): LinkCache doesn't currently know about this title
Not worse than previous releases
- (bug 37714): [Regression] Incomplete log entries
c27869 addresses this
- (bug 38334): PHP Notice: Undefined index: href in
/www/w/skins/Vector.php on line 416
It would be nice to fix it, although it's probably some extension.
- (bug 39268): [Regression] Toolbar inserts in main textarea only
(instead of the focussed textarea)
Should mention ProofreadPage, which is apparently the extension triggering it.
- (bug 40598): [Regression] jquery.localize tests are failing in IE6-8
I don't really see what the bug is with the description.
- (bug 40632): Kill $wgCleanupPresentationalAttributes from MediaWiki core
Not worse than 1.19
- (bug 40641): Clicking "others" in Special:Version asks to download a file
Configuration dependant. Very minor.
- (bug 40780): searchsuggest-containing line ("containing...") doesn't
include the entered text
There's a patch at c27386.
- (bug 40939): [Regression] InfoAction: Call to a member function
getUserText() on a non-object
action=info on a non-existant page executes fine for me on REL1_20 (287a4a6), although the content is wrong.
PS: I have a tag 1.20.0rc1 pointing to 1.12.0rc1 (a 2008 revision), but doesn't appear on https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tags Tagging failure or user error?
On 10/14/2012 12:14 PM, Platonides wrote:
As these look a bit like "shipping with ugly bugs", I have done a quick check of their severity:
Thank you so much for this. I'd like to get an assessment like this of of these issues incorporated into the release notes. I think it will better help people understand if the issue affects them.
(As far as "shipping with ugly bugs"... I think there are some bugs in Bugzilla that have proven very irksome to *some* users so I don't think we're any worse off by saying publicly that we have scheduled this particular set to be fixed.
PS: I have a tag 1.20.0rc1 pointing to 1.12.0rc1 (a 2008 revision), but doesn't appear on https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tags Tagging failure or user error?
PEBKAC? I don't know enough about how Gerrit handles tags from the non-MW group, but I suspect it would have to have some intervention of someone in that group (I'm not a member) for you to see tags that someone else put on a revision.
Mark.
On 14/10/12 20:46, Mark A. Hershberger wrote:
PEBKAC? I don't know enough about how Gerrit handles tags from the non-MW group, but I suspect it would have to have some intervention of someone in that group (I'm not a member) for you to see tags that someone else put on a revision.
Mark.
I probably messed up myself. What revision did you use for the rc1?
On Mon 15 Oct 2012 11:25:28 AM EDT, Platonides wrote:
I probably messed up myself. What revision did you use for the rc1?
https://gerrit.wikimedia.org/r/#/c/27370/ plus the attached diff (which I cannot now submit because of firewall issues).
On 15/10/12 17:52, Mark A. Hershberger wrote:
On Mon 15 Oct 2012 11:25:28 AM EDT, Platonides wrote:
I probably messed up myself. What revision did you use for the rc1?
https://gerrit.wikimedia.org/r/#/c/27370/ plus the attached diff (which I cannot now submit because of firewall issues).
I have submitted it for you https://gerrit.wikimedia.org/r/28296 [92525a496c6b77a044dae42ebe6360b08093cf9c]
I also set a tag 1.20.0rc1 to that revision (or so I think)
For the record, the differences with the tarball are:
Only in core/: .git Only in core/: .gitignore Only in core/: .gitreview Only in core/: .jshintignore Only in core/: .jshintrc Only in core/docs/html: .gitignore Only in core/extensions: .gitignore Only in core/includes/zhtable: .gitignore Only in mediawiki-1.20.0rc1/extensions: ConfirmEdit Only in mediawiki-1.20.0rc1/extensions: Gadgets Only in mediawiki-1.20.0rc1/extensions: Nuke Only in mediawiki-1.20.0rc1/extensions: ParserFunctions Only in mediawiki-1.20.0rc1/extensions: Renameuser Only in mediawiki-1.20.0rc1/extensions: Vector Only in mediawiki-1.20.0rc1/extensions: WikiEditor
Basically, removal of config files which are there just for development.
I'm not sure if we should include the bundled extensions as submodules in the tagged releases. Opinions?
PS: Note that REL1_20 got a new fix for bug 40780. I would delay the release and try to get the listed bugs with patches merged for 1.20. As those are changes from rc1, IMHO we should also ship a rc2 before going final.
On 10/16/2012 05:33 PM, Platonides wrote:
Basically, removal of config files which are there just for development.
Right. And this is part of https://gerrit.wikimedia.org/r/#/c/23919/
PS: Note that REL1_20 got a new fix for bug 40780. I would delay the release and try to get the listed bugs with patches merged for 1.20. As those are changes from rc1, IMHO we should also ship a rc2 before going final.
I'll put out RC2 tonight or tomorrow. But I would like to get 1.20 out today or tomorrow.
Mark.
I think an rc2 is a good idea. The "Known Issues" section of the RELEASE-NOTES-1.20 has shrunk and I've used Platonides comments to update that section so that people can see whether or not they are affected. In any case here is what it looks like (with some editing of my own for this email:
* (bug 35894): Reports of secret key generation "hanging" on windows This is probably a bug that has been fixed in PHP. If you run into this, try upgrading your PHP. * (bug 38334): Undefined index: href in Vector.php on line 416 We think this is a problem in some extension. If you see this, try disabling your extensions and check out the logging patch on this bug. Or try this patch: https://gerrit.wikimedia.org/r/#/c/27937/1/skins/Vector.php * (bug 39268): [Regression] Toolbar inserts in main textarea only This should only be an issue if you are using the ProofreadPage extension. * (bug 40641): Clicking "others" in Special:Version downloads a file If you encounter this, you can tell your webserver to serve the CREDITS file with text/plain MIME type to fix it.
Full release notes: http://mah.everybody.org/mediawiki/1.20/RELEASE-NOTES-1.20.txt
********************************************************************** Download: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.tar.gz
Patch to previous version (1.20.0rc1), without interface text: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.patch.gz Interface text changes: http://mah.everybody.org/mediawiki/1.20/mediawiki-i18n-1.20.0rc2.patch.gz
GPG signatures: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.tar.gz.sig http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.patch.gz.sig http://mah.everybody.org/mediawiki/1.20/mediawiki-i18n-1.20.0rc2.patch.gz.si...
Public keys: https://mah.everybody.org/contact-info
mediawiki-l@lists.wikimedia.org