Cheers MW developers -- simple question:
I am working on my first bug-fix (see https://bugzilla.wikimedia.org/show_bug.cgi?id=43571) and have submitted a patch (see https://gerrit.wikimedia.org/r/#/c/65301/.) I would like to address the issues brought up by Hashar, who has been kind enough to review and comment on the patch.
What is the correct way to submit a new patchset to Gerrit?
I am new to Git and am slightly overwhelmed by the copious documentation on MW.org (not a bad thing.) Should I 'git pull origin master' and then 'git rebase'? Or do just just run 'git review -R' again to send my patch?
--User:AlephNull (a.k.a. Daniel Renfro)
If you are working on the same branch from which you submitted the patch earlier the following works:
'git commit --amend' - to amend the change
'git review' -to submit it to gerrit as a new patchset.
On Thu, May 30, 2013 at 7:45 AM, Daniel Renfro drenfro@vistaprint.comwrote:
Cheers MW developers -- simple question:
I am working on my first bug-fix (see https://bugzilla.wikimedia.org/show_bug.cgi?id=43571) and have submitted a patch (see https://gerrit.wikimedia.org/r/#/c/65301/.) I would like to address the issues brought up by Hashar, who has been kind enough to review and comment on the patch.
What is the correct way to submit a new patchset to Gerrit?I am new to Git and am slightly overwhelmed by the copious documentation on MW.org (not a bad thing.) Should I 'git pull origin master' and then 'git rebase'? Or do just just run 'git review -R' again to send my patch?
--User:AlephNull (a.k.a. Daniel Renfro)
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
mediawiki-l@lists.wikimedia.org