Hi Jim,
On 5/27/07 12:42 PM, "Jim Wilson" wilson.jim.r@gmail.com wrote:
Without going into too much detail, the current implementation of ExtendedSyntaxParser, while operating fine by itself, is not amicable to running along side certain other kinds of extensions. It's something that I've wanted to revisit, but haven't had time to do so just
yet.
Since I wrote TabbedData, I'm wondering what the incompatibility is? Is there something I can change in TabbedData to make this work?
BTW, the UsenetSyntax page makes no mention of requiring ExtendedSyntaxParser, and I can't find it on mw.org... where do I get it?
Ian
Hi Ian,
To expand on my comment that ExtendedSyntaxParser doesn't always play well with other extensions, I added a section to the MarkdownSyntax talk page:
http://www.mediawiki.org/wiki/Extension_talk:MarkdownSyntax#Incompatibilitie...
Basicall (in summary) ExtendedSyntaxParser will strip out HTML comments <!-- like this --> from the rendered wiki page. HTML comments are already stripped out of wikitext when rendering a page, so for a vanilla install this poses no problem.
However, if an extension adds HTML comments to an article's rendered body, they'll be stripped and this can interfere with functionality. For example, this would break WikiArticleFeeds (another extension of mine).
I've updated the instructions for the UsenetSyntax extension to include downloading and installing ExtendedSyntaxParser, which you can get here:
http://jimbojw.com/wiki/index.php?title=ExtendedSyntaxParser
I haven't documented this extension on MediaWiki.org (or my own site) due to the HTML comment parsing problem I indicated above.
As far as I can tell, there's no good reason why ESP and TabbedData couldn't live in perfect harmony. I have no evidence to support Simon's assertion that they don't.
-- Jim R. Wilson (jimbojw)
On 5/29/07, Ian Smith johantheghost@yahoo.com wrote:
Hi Jim,
On 5/27/07 12:42 PM, "Jim Wilson" wilson.jim.r@gmail.com wrote:
Without going into too much detail, the current implementation of ExtendedSyntaxParser, while operating fine by itself, is not amicable to running along side certain other kinds of extensions. It's something that I've wanted to revisit, but haven't had time to do so
just yet.
Since I wrote TabbedData, I'm wondering what the incompatibility is? Is there something I can change in TabbedData to make this work?
BTW, the UsenetSyntax page makes no mention of requiring ExtendedSyntaxParser, and I can't find it on mw.org... where do I get it?
Ian
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
Jim,
Thanks for the explanation.
Basicall (in summary) ExtendedSyntaxParser will strip out HTML comments ... ... if an extension adds HTML comments to an article's rendered body, they'll be stripped and this can interfere with functionality. ... As far as I can tell, there's no good reason why ESP and TabbedData couldn't live in perfect harmony. I have no evidence to support Simon's assertion that they don't.
I can't see why they wouldn't; TabbedData doesn't use HTML comments. I just installed ExtendedSyntaxParser and UsenetSyntax into my wiki (which already has TabbedData), and I could use both UsenetSyntax and TabbedData in the same page, no problems. This is on MediaWiki 1.9.3.
Having said that, I got this error on all page loads (I have PHP error reporting enabled):
<b>Warning</b>: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of xml_set_object(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in <b>C:\WebServer\wiki-common\extensions\ExtendedSyntaxParser.php</b> on line <b>130</b><br />
Ian
Yeah - that call-time pass-by-reference warning refers to the practice of passing an argument to a function by reference using the &$varname syntax.
I've updated the extension to fix this, so if you re-download it the problem should go away.
-- Jim
On 5/29/07, Ian Smith johantheghost@yahoo.com wrote:
Jim,
Thanks for the explanation.
Basicall (in summary) ExtendedSyntaxParser will strip out HTML comments
...
... if an extension adds HTML comments to an article's rendered body, they'll be stripped and this can interfere with functionality. ... As far as I can tell, there's no good reason why ESP and TabbedData couldn't live in perfect harmony. I have no evidence to support
Simon's
assertion that they don't.
I can't see why they wouldn't; TabbedData doesn't use HTML comments. I just installed ExtendedSyntaxParser and UsenetSyntax into my wiki (which already has TabbedData), and I could use both UsenetSyntax and TabbedData in the same page, no problems. This is on MediaWiki 1.9.3.
Having said that, I got this error on all page loads (I have PHP error reporting enabled):
<b>Warning</b>: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of xml_set_object(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in <b>C:\WebServer\wiki-common\extensions\ExtendedSyntaxParser.php</b> on line <b>130</b><br />
Ian
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
On May 29, 2007, at 4:19 PM, Jim Wilson wrote:
Hi Ian,
To expand on my comment that ExtendedSyntaxParser doesn't always play well with other extensions, I added a section to the MarkdownSyntax talk page:
http://www.mediawiki.org/wiki/ Extension_talk:MarkdownSyntax#Incompatibilities
Basicall (in summary) ExtendedSyntaxParser will strip out HTML comments <!-- like this --> from the rendered wiki page. HTML comments are already stripped out of wikitext when rendering a page, so for a vanilla install this poses no problem.
If I'm understanding this correctly, it should not be a problem with extensions like my TableEdit, which use HTML comments to mark positions in the wikitext. The stripping should happen after TableEdit, which hooks at ArticleSave, is done. Is that correc?
Jim
However, if an extension adds HTML comments to an article's rendered body, they'll be stripped and this can interfere with functionality. For example, this would break WikiArticleFeeds (another extension of mine).
I've updated the instructions for the UsenetSyntax extension to include downloading and installing ExtendedSyntaxParser, which you can get here:
http://jimbojw.com/wiki/index.php?title=ExtendedSyntaxParser
I haven't documented this extension on MediaWiki.org (or my own site) due to the HTML comment parsing problem I indicated above.
As far as I can tell, there's no good reason why ESP and TabbedData couldn't live in perfect harmony. I have no evidence to support Simon's assertion that they don't.
-- Jim R. Wilson (jimbojw)
On 5/29/07, Ian Smith johantheghost@yahoo.com wrote:
Hi Jim,
On 5/27/07 12:42 PM, "Jim Wilson" wilson.jim.r@gmail.com wrote:
Without going into too much detail, the current implementation of ExtendedSyntaxParser, while operating fine by itself, is not amicable to running along side certain other kinds of extensions. It's something that I've wanted to revisit, but haven't had time to do so
just yet.
Since I wrote TabbedData, I'm wondering what the incompatibility is? Is there something I can change in TabbedData to make this work?
BTW, the UsenetSyntax page makes no mention of requiring ExtendedSyntaxParser, and I can't find it on mw.org... where do I get it?
Ian
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
===================================== Jim Hu Associate Professor Dept. of Biochemistry and Biophysics 2128 TAMU Texas A&M Univ. College Station, TX 77843-2128 979-862-4054
I haven't looked closely at the TableEdit code - but if I'm reading your message correctly, then no, it shouldn't conflict.
-- Jim
On 5/29/07, Jim Hu jimhu@tamu.edu wrote:
On May 29, 2007, at 4:19 PM, Jim Wilson wrote:
Hi Ian,
To expand on my comment that ExtendedSyntaxParser doesn't always play well with other extensions, I added a section to the MarkdownSyntax talk page:
http://www.mediawiki.org/wiki/ Extension_talk:MarkdownSyntax#Incompatibilities
Basicall (in summary) ExtendedSyntaxParser will strip out HTML comments <!-- like this --> from the rendered wiki page. HTML comments are already stripped out of wikitext when rendering a page, so for a vanilla install this poses no problem.
If I'm understanding this correctly, it should not be a problem with extensions like my TableEdit, which use HTML comments to mark positions in the wikitext. The stripping should happen after TableEdit, which hooks at ArticleSave, is done. Is that correc?
Jim
However, if an extension adds HTML comments to an article's rendered body, they'll be stripped and this can interfere with functionality. For example, this would break WikiArticleFeeds (another extension of mine).
I've updated the instructions for the UsenetSyntax extension to include downloading and installing ExtendedSyntaxParser, which you can get here:
http://jimbojw.com/wiki/index.php?title=ExtendedSyntaxParser
I haven't documented this extension on MediaWiki.org (or my own site) due to the HTML comment parsing problem I indicated above.
As far as I can tell, there's no good reason why ESP and TabbedData couldn't live in perfect harmony. I have no evidence to support Simon's assertion that they don't.
-- Jim R. Wilson (jimbojw)
On 5/29/07, Ian Smith johantheghost@yahoo.com wrote:
Hi Jim,
On 5/27/07 12:42 PM, "Jim Wilson" wilson.jim.r@gmail.com wrote:
Without going into too much detail, the current implementation of ExtendedSyntaxParser, while operating fine by itself, is not amicable to running along side certain other kinds of extensions. It's something that I've wanted to revisit, but haven't had time to do so
just yet.
Since I wrote TabbedData, I'm wondering what the incompatibility is? Is there something I can change in TabbedData to make this work?
BTW, the UsenetSyntax page makes no mention of requiring ExtendedSyntaxParser, and I can't find it on mw.org... where do I get it?
Ian
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
===================================== Jim Hu Associate Professor Dept. of Biochemistry and Biophysics 2128 TAMU Texas A&M Univ. College Station, TX 77843-2128 979-862-4054
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
I updated MarkdownSyntax [1] to use ParserBeforeStrip instead of ExtendedSyntaxParser. I think everything is working now. Please try it out if you're interested and report any success or failures.
Thanks, Simon
Hi Simon,
I took a look at your extension and started making modifications. After a while at that, I realized that it would probably be more useful (for my own purposes) to extend the original design to support multiple syntaxes and bypass the Parser's wikitext engine rather than just hijacking it at the front.
The result is an extension called AlternateSyntaxParser, which supports both Markdown and Textile out-of-the-box and allows per-page inline configuration as well as a site-wide default. For more details, see MediaWiki extension page:
http://www.mediawiki.org/wiki/Extension:AlternateSyntaxParser
Check out the developer notes section for a description of how the implementation differs from MarkdownSyntax. Or, feel free to review the source code which is available here:
http://jimbojw.com/wiki/index.php?title=AlternateSyntaxParser
I'll be happy to answer any questions - thanks!
-- Jim R. Wilson (jimbojw)
On 6/2/07, Simon Dorfman emaillists@simondorfman.com wrote:
I updated MarkdownSyntax [1] to use ParserBeforeStrip instead of ExtendedSyntaxParser. I think everything is working now. Please try it out if you're interested and report any success or failures.
Thanks, Simon
[1] http://www.mediawiki.org/wiki/Extension:MarkdownSyntax
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
mediawiki-l@lists.wikimedia.org