Thank you, I much appreciate you fixing this! I added your "public function" inside my :
class SkinZedDocs extends SkinVector { ... }
class and it seems to work again. I will have to cross my fingers and hope this doesn't break again because, not knowing PHP, I can't fix it myself. Luckily I test an upgrade first!
Many Thanks.
On Sun, Jan 18, 2015, at 07:48 PM, Legoktm wrote:
Hi,
On 01/16/2015 12:08 AM, Alastair Sherringham wrote:
require_once( dirname( __FILE__ ) . '/../Vector.php' );
If I remove this line as per Daniel Friesen on last mediawiki-l thread, I get error :
[Tue Jan 13 16:38:50 2015] [error] [client 192.168.0.124] PHP Catchable fatal error: Argument 1 passed to SkinVector::__construct() must implement interface Config, string given, called in /home/user/mediawiki-1.24.1/includes/Setup.php on line 285 and defined in /home/user/mediawiki-1.24.1/skins/Vector/SkinVector.php on line 38, referer: http://wpdev/w/index.php?title=Main_Page
Unfortunately, I don't follow what to do from Daniel's suggestion about the way Vector now works. I have tried to set up my skin files (and renamed) as per the Skin_autodiscovery manual page.
Sorry, this is my fault. :/ I've uploaded a patch[1] to fix this.
For now you can add:
public function __construct() { parent::__construct( ConfigFactory::getDefaultInstance()->makeConfig( 'vector' ) ); }
to your SkinZedDocs class, which should fix the issue.
[1] https://gerrit.wikimedia.org/r/#/c/185695/
-- Legoktm
MediaWiki-l mailing list To unsubscribe, go to: https://lists.wikimedia.org/mailman/listinfo/mediawiki-l