Guys, who can fix bugs T112460, T112461, T112462? They are critical for wlm maintenance IMHO.
Hi,
2015-09-25 19:58 GMT+01:00 Anatoliy Goncharov ahonc.ua@gmail.com:
Guys, who can fix bugs T112460, T112461, T112462? They are critical for wlm maintenance IMHO.
Well, anyone can submit patches to the public [Git repository] ;-)
More seriously, I just closed T112461 and T112462.
[T112460] is a bit more tricky.
Hope that helps,
Dear Jean-Fred,
I have opened T112461 It does not work for Ukrainian lists: http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&...
Best regards, antanana ED of Wikimedia Ukraine
2015-09-26 4:14 GMT+03:00 Jean-Frédéric jeanfrederic.wiki@gmail.com:
Hi,
2015-09-25 19:58 GMT+01:00 Anatoliy Goncharov ahonc.ua@gmail.com:
Guys, who can fix bugs T112460, T112461, T112462? They are critical for wlm maintenance IMHO.
Well, anyone can submit patches to the public [Git repository] ;-)
More seriously, I just closed T112461 and T112462.
[T112460] is a bit more tricky.
Hope that helps,
-- Jean-Fred
[Git repository) < http://git.wikimedia.org/summary/labs%2Ftools%2Fheritage.git%3E [T112460] https://phabricator.wikimedia.org/T112460
Wiki Loves Monuments mailing list WikiLovesMonuments@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikilovesmonuments http://www.wikilovesmonuments.org
Hi antanana,
I have opened T112461
It does not work for Ukrainian lists:
http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&...
I’m pretty sure this is https://phabricator.wikimedia.org/T112460
Is it blocked by T112460?
Best regards, antanana ED of Wikimedia Ukraine
2015-10-15 11:59 GMT+03:00 Jean-Frédéric jeanfrederic.wiki@gmail.com:
Hi antanana,
I have opened T112461
It does not work for Ukrainian lists:
http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&...
I’m pretty sure this is https://phabricator.wikimedia.org/T112460
-- Jean-Frédéric
2015-10-15 10:15 GMT+01:00 attolippip attolippip@gmail.com:
Is it blocked by T112460?
I’m not sure what you mean. T112461 was specifically an issue where sources were not linked because the format did not match the expected one − combination of protocol-relative URLs, expected bits ?useskin= which were not there anymore (possibly following the pywikibot upgrade ? never really checked) − and I fixed it last month.
A different issue is that fields in the database are limited to a certain size, and when source links are too long they get truncated − if you look at the link in the monument you sent, it is cut way before reaching the oldid. This issue is tracked at T112460.
Well, URL is cutted, but there are also no <a href> tags, If T112461 is fixed, it should generate link. Yes, link will be incorrect for uk, but it should be generated.
2015-10-15 12:28 GMT+03:00 Jean-Frédéric <jeanfrederic.wiki@gmail.com>:
2015-10-15 10:15 GMT+01:00 attolippip <attolippip@gmail.com>:
Is it blocked by T112460?
I’m not sure what you mean. T112461 was specifically an issue where sources were not linked because the format did not match the expected one − combination of protocol-relative URLs, expected bits ?useskin= which were not there anymore (possibly following the pywikibot upgrade ? never really checked) − and I fixed it last month.
A different issue is that fields in the database are limited to a certain size, and when source links are too long they get truncated − if you look at the link in the monument you sent, it is cut way before reaching the oldid. This issue is tracked at T112460.
Wiki Loves Monuments mailing list WikiLovesMonuments@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikilovesmonuments http://www.wikilovesmonuments.org
2015-10-15 10:59 GMT+01:00 Анатолій Гончаров ahonc.ua@gmail.com:
Well, URL is cutted, but there are also no <a href> tags
Well, yeah, because the link generator expects a non-cut URL. It is not 'just' a matter of slapping <a> tags around the field − it’s not super advanced, but there is somme formatting going on [1]
If T112461 is fixed, it should generate link.
No, there are many possible bugs that could prevent link to be generated. T112461 was about a specific one (as stated in the task title, « because of new URL format »), and this one is fixed.
But if that makes it clearer, I just filed < https://phabricator.wikimedia.org/T115572>
[1] https://phabricator.wikimedia.org/rTHER2be5c388e70187b522cf054c8dfdc8f605a0c865
So, if we already have URL with oldid we can cut 'title' from it before saving (explode query_string by & and take only part with 'oldid'). In such case we will have short URL like https://uk.wikipedia.org/w/index.php?oldid=16797698 , and it will store in database correctly,
2015-10-15 13:24 GMT+03:00 Jean-Frédéric jeanfrederic.wiki@gmail.com:
2015-10-15 10:59 GMT+01:00 Анатолій Гончаров ahonc.ua@gmail.com:
Well, URL is cutted, but there are also no <a href> tags
Well, yeah, because the link generator expects a non-cut URL. It is not 'just' a matter of slapping <a> tags around the field − it’s not super advanced, but there is somme formatting going on [1]
If T112461 is fixed, it should generate link.
No, there are many possible bugs that could prevent link to be generated. T112461 was about a specific one (as stated in the task title, « because of new URL format »), and this one is fixed.
But if that makes it clearer, I just filed < https://phabricator.wikimedia.org/T115572>
[1] https://phabricator.wikimedia.org/rTHER2be5c388e70187b522cf054c8dfdc8f605a0c865 -- Jean-Frédéric
Wiki Loves Monuments mailing list WikiLovesMonuments@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikilovesmonuments http://www.wikilovesmonuments.org
Multichill has added a comment to T112460 Is it possible to do it now?
Best regards, antanana ED of Wikimedia Ukraine
2015-10-15 13:24 GMT+03:00 Jean-Frédéric jeanfrederic.wiki@gmail.com:
2015-10-15 10:59 GMT+01:00 Анатолій Гончаров ahonc.ua@gmail.com:
Well, URL is cutted, but there are also no <a href> tags
Well, yeah, because the link generator expects a non-cut URL. It is not 'just' a matter of slapping <a> tags around the field − it’s not super advanced, but there is somme formatting going on [1]
If T112461 is fixed, it should generate link.
No, there are many possible bugs that could prevent link to be generated. T112461 was about a specific one (as stated in the task title, « because of new URL format »), and this one is fixed.
But if that makes it clearer, I just filed < https://phabricator.wikimedia.org/T115572>
[1] https://phabricator.wikimedia.org/rTHER2be5c388e70187b522cf054c8dfdc8f605a0c865 -- Jean-Frédéric
Wiki Loves Monuments mailing list WikiLovesMonuments@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikilovesmonuments http://www.wikilovesmonuments.org
Follow-up: [T115572] has now been closed (thanks to André’s work with T112460) ; there is some additional work on [T132029].
Cheers,
wikilovesmonuments@lists.wikimedia.org