On Wed, 26 Dec 2012 16:37:47 -0800, Ori Livneh &lt;ori(a)wikimedia.org&gt; wrote: Hi, Why is a list of commits considered valid evidence for determining if someone is worth giving +2? One does not review their own commits. The commits made by the user themselves are irrelevant as it would be irresponsible for the +2 to be given in order for said line of commits to be reviewed. The +2 is for use in reviewing other users' commits. More to the point, better evidence would be a history of -1 and +1 the user has made. Are the user's +1's in line with whether a +2 was eventually made (not retaining +1 on something that was decided should be rejected)? Does the user make +1 and -1's to aid review of commits that don't get much review from others till after the user has already been helping review the commits for awhile? etc... -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] ______________________________**_________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-l<https://lists.…

On Saturday, January 5, 2013 at 2:08 PM, Alex Monk wrote: The best I could come up with is: reviewer:krenair project:mediawiki/core -owner:krenair (label:CodeReview=1 OR label:CodeReview=-1) https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+project:mediawiki/core+… It seems more useful to cast a wider net, though: reviewer:krenair -owner:krenair https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+-owner:krenair,n,z I'll add them to the request on MediaWiki.org.