On Wed, 26 Dec 2012 16:37:47 -0800, Ori Livneh ori@wikimedia.org wrote:
Hi,
Just a heads-up that I nominated Krenair (Alex Monk) for inclusion in mediawiki/core: http://www.mediawiki.org/wiki/Git/Gerrit_project_ownership#Krenair_for_Media...
For supporting evidence, see:
https://gerrit.wikimedia.org/r/#/q/owner:krenair+project:mediawiki/core,n,z
https://bugzilla.wikimedia.org/buglist.cgi?query_format=specific&product...
Please consider weighing in. Thanks, Ori
-- Ori Livneh
Why is a list of commits considered valid evidence for determining if someone is worth giving +2?
One does not review their own commits. The commits made by the user themselves are irrelevant as it would be irresponsible for the +2 to be given in order for said line of commits to be reviewed. The +2 is for use in reviewing other users' commits.
More to the point, better evidence would be a history of -1 and +1 the user has made. Are the user's +1's in line with whether a +2 was eventually made (not retaining +1 on something that was decided should be rejected)? Does the user make +1 and -1's to aid review of commits that don't get much review from others till after the user has already been helping review the commits for awhile? etc...