alnokta(a)svn.wikimedia.org wrote:
> Revision: 35812
> Author: alnokta
> Date: 2008-06-03 18:55:44 +0000 (Tue, 03 Jun 2008)
>
> Log Message:
> -----------
> Enable external link icon (along with other links icons too) again on RTL wikis after correcting its behavior.
> This time it only adds 1.7kb of code. tested it on Arabic and English wikis. patch by Ahmad Sherif.
>
> Modified Paths:
> --------------
> trunk/phase3/skins/monobook/main.css
> trunk/phase3/skins/monobook/rtl.css
>
This doesn't work properly in Firefox 2.0.0.14, see:
http://commons.wikimedia.org/wiki/Image:MediaWikiRTLExternalLinkIcon.png
As far as I recall, this is a bug in Firefox. It may be fixed in Firefox 3.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Can you please explain what this change is for? AFAIK we have proper fallback from 'sr' to 'sr-ec', from 'zh' to 'zh-hans', and from 'zh-kh' to 'zh-hant' as configured in the corresponding messages files. This should work for all extensions using $wgExtensionMessagesFiles, which is true for BoardVote.
Siebrand
-----Oorspronkelijk bericht-----
Van: mediawiki-cvs-bounces(a)lists.wikimedia.org
Verzonden: dinsdag 3 juni 2008 20:02
Aan: mediawiki-cvs(a)lists.wikimedia.org
Onderwerp: [MediaWiki-CVS] SVN: [35806]trunk/extensions/BoardVote/BoardVote.i18n.php
Revision: 35806
Author: ktchan
Date: 2008-06-03 18:01:30 +0000 (Tue, 03 Jun 2008)
Log Message:
-----------
Copy 'sr-ec' to 'sr', 'zh-hans' to 'zh', 'zh-hant' to 'zh-hk'
Modified Paths:
--------------
trunk/extensions/BoardVote/BoardVote.i18n.php
On Tue, Jun 3, 2008 at 1:36 AM, <siebrand(a)svn.wikimedia.org> wrote:
> -'specialpages-note' => '<hr /><ul>
> -<li>Normal special pages.</li>
> -<li class="mw-specialpagerestricted">Restricted special pages.</li>
> -</ul>',
> +'specialpages-note' => '----
> +* Normal special pages.</li>
> +* <span class="mw-specialpagerestricted">Restricted special pages.</span>',
This change is incorrect. The star is overtyped on the bullet, at
least in Firefox 3, and I'm pretty sure that's what the standard
requires in this case (plus who knows what relying on display:
list-item will do for compatibility; I doubt it works with IE6).
A better change, if this message is to be kept altogether (see my last
post to the list), is to break this into two messages, saying "Normal
special pages." and "Restricted special pages.", and hard-code the
HTML (or put the HTML in its own message and use $1 and $2 for the
text). It's not a good idea to mix linguistic and non-linguistic
content in messages, because it makes it impossible to change the
non-linguistic content easily.
> From: demon(a)svn.wikimedia.org <demon(a)svn.wikimedia.org>
> Date: Jun 3, 2008 4:53 PM
> Subject: [MediaWiki-CVS] SVN: [35794] trunk/phase3
> To: mediawiki-cvs(a)lists.wikimedia.org
>
>
> Revision: 35794
> Author: demon
> Date: 2008-06-03 14:53:47 +0000 (Tue, 03 Jun 2008)
>
> Log Message:
> -----------
> (bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding
> the 'noratelimit' user right.
>
[...]
> + $createAdminSettings = importCheck('createadminsettings', false);
> $conf->LanguageCode = importPost( "LanguageCode", "en" );
>
[...]
That should probably also have been in the release notes as well as in
the relevant bugzilla entry.
Bryan
Sorry, this is going to be a blatant rant...
Request: http://www.wikia.com/api.php?action=query&list=categorymembers&cmtitle=Cate…
Result:
<?xml version="1.0" encoding="utf-8"?>
<api>
<error code="cmtitleandcategory" info="The cmcategory and cmtitle parameters can't be used together" />
</api>
How are people supposed to write tools that work with sites other than
Wikipedia when things change fast and non-intrusive fallbacks for
older versions are specifically blocked? Please remember that
MediaWiki is not used only on Wikimedia, where SVN HEAD is just fine.
It is used by thousands of other sites, many of which are older, but
still can benefit from bot tools. And I can't just get
the MediaWiki version before retrieving categories, because that
would disqualify those who use 1.12 pre-releases. Thanks Satan this at
least was removed soon after the release.
The moral: please think of long-term consequences of your changes, if
you change the way a piece of code works, at least (pleeeease!) allow
people to fall back without much PITA.
And can this mistake be fixed at least in service releases for 1.12?
--
Max Semenik ([[User:MaxSem]])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
dantman(a)svn.wikimedia.org wrote:
> Allow use of a mediawiki message to '''override''' the group used to group a special page.
> Form is specialpages-specialpagegroup-$specialpage
Isn't that a bit repetitive? :)
Maybe something a little shorter like "specialpages-group-$name"...
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhEOXQACgkQwRnhpk1wk46vPQCaA/pcNnXjzWEQfUHApTxRKsa2
Z48AoM6SmkWBBXiWsxhzjWjB0nW4B9ik
=QEHj
-----END PGP SIGNATURE-----
btongminh(a)svn.wikimedia.org schreef:
> Revision: 35681
> Author: btongminh
> Date: 2008-06-01 17:58:27 +0000 (Sun, 01 Jun 2008)
>
> Log Message:
> -----------
> API: Add action=emailuser
>
>
> Modified: trunk/phase3/RELEASE-NOTES
> ===================================================================
> +* Added action=emailuser to send an email to a user
>
> <snip>
> + $this->getMain()->requestWriteMode();
>
Do we really need requestWriteMode() here? Sending e-mails through the
wiki doesn't really qualify as writing IMO.
> <snip>
> + // FIXME: How to properly get a token?
>
Add a gettoken parameter like action=block and action=unblock have.
Roan Kattouw (Catrope)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
minuteelectron(a)svn.wikimedia.org wrote:
> +* (bug 14370) When a grouppage-x message does not exist the entry on the
> + ListGroupRights special page links to the main namespace page not the project
> + namespace page.
This commit does the opposite of its description. Please correct the
comment to describe the *result* of the code change.
> - $grouppageLocalized = $groupname;
> + $grouppageLocalized = MWNamespace::getCanonicalName( NS_PROJECT ) . ':' . $groupname;
- -- brion vibber (brion @ wikimedia.org)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhEJqUACgkQwRnhpk1wk44urACeJGJnu57RejHbvv6W4HbXkMQo
QAIAn2VzbxPv16rpApGPYZG/CKRh+B8U
=mOUC
-----END PGP SIGNATURE-----
On Sun, Jun 1, 2008 at 7:47 PM, <dantman(a)svn.wikimedia.org> wrote:
> showDiff needs headers as parameters, even though they aren't needed here. Just give it two empty strings to avoid a PHP error.
This is what parameter defaults are good for, yes?
