btongminh@svn.wikimedia.org schreef:
Revision: 35681 Author: btongminh Date: 2008-06-01 17:58:27 +0000 (Sun, 01 Jun 2008)
Log Message:
API: Add action=emailuser
Modified: trunk/phase3/RELEASE-NOTES
+* Added action=emailuser to send an email to a user
<snip> + $this->getMain()->requestWriteMode();
Do we really need requestWriteMode() here? Sending e-mails through the wiki doesn't really qualify as writing IMO.
<snip> + // FIXME: How to properly get a token?
Add a gettoken parameter like action=block and action=unblock have.
Roan Kattouw (Catrope)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Roan Kattouw wrote:
btongminh@svn.wikimedia.org schreef:
Revision: 35681 Author: btongminh Date: 2008-06-01 17:58:27 +0000 (Sun, 01 Jun 2008)
Log Message:
API: Add action=emailuser
Modified: trunk/phase3/RELEASE-NOTES
+* Added action=emailuser to send an email to a user
<snip> + $this->getMain()->requestWriteMode();
Do we really need requestWriteMode() here? Sending e-mails through the wiki doesn't really qualify as writing IMO.
"Write-mode" should apply to any action that has side effects (modifying data, causing anything to be sent to a third-party, etc).
It *must* be possible to clearly demarcate between read-only data access and stuff that does stuff.
For that matter I'm verrrrrrrry leery of any automated interface for email such as this.
- -- brion
On Mon, Jun 2, 2008 at 5:45 PM, Brion Vibber brion@wikimedia.org wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Roan Kattouw wrote:
btongminh@svn.wikimedia.org schreef:
Revision: 35681 Author: btongminh Date: 2008-06-01 17:58:27 +0000 (Sun, 01 Jun 2008)
Log Message:
API: Add action=emailuser
[...]
For that matter I'm verrrrrrrry leery of any automated interface for email such as this.
It is not providing anything additional above the normal Special:Emailuser. Using Special:Emailuser to send batch emails is very easy. The advantage of the API in this case is that you can properly check whether something has gone wrong or not.
Bryan
wikitech-l@lists.wikimedia.org