-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
btongminh(a)svn.wikimedia.org wrote:
+ // Check permissions
+ $errors = EmailUserForm::getPermissionsError( $params['target'] );
+ if ( $errors )
+ $this->dieUsageMsg( $errors[0] );
+
+ // Rate limiter
+ if( $wgUser->pingLimiter( 'emailuser' ) )
+ $this->dieUsageMsg( 'actionthrottledtext' );
This seems to be duplicating a couple of active checks (permissions,
rate limits...), maybe a little refactoring to the backend could
eliminate that?
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla -
http://enigmail.mozdev.org
iEYEARECAAYFAkhEOVEACgkQwRnhpk1wk444jwCfdiF3ffGH8Orw5TZzIwl4elVt
+8QAoJza5SVz4zvdhTDjyrJbxHntG06A
=YYAh
-----END PGP SIGNATURE-----