catrope(a)svn.wikimedia.org wrote:
> + $hasHistory = false;
> + $reason = $article->generateReason($hasHistory);
Can we not modify Article::generateReason() to not forced a reference,
since, AFAIK, you no longer have to explicitly state that a parameter
should be a reference.
MinuteElectron.
On Sun, May 25, 2008 at 8:17 PM, <simetrical(a)svn.wikimedia.org> wrote:
> Log Message:
> -----------
> Yoris on IRC points out that it used to be standard practice for extensions to create files in the includes directory, ca. two and a half years ago: http://www.mediawiki.org/w/index.php?title=Manual:Special_pages&oldid=10718… Add a note to this effect to UPGRADE.
Well, maybe not standard, but at least recommended (incorrectly) for a
period of six months by the unofficial mediawiki.org documentation.
btongminh(a)svn.wikimedia.org wrote:
> Log Message:
> -----------
> * Add wfRunHook calls where appropriate
>
> Modified Paths:
> --------------
> trunk/phase3/includes/api/ApiBlock.php
> trunk/phase3/includes/api/ApiDelete.php
> trunk/phase3/includes/api/ApiEditPage.php
> trunk/phase3/includes/api/ApiLogout.php
> trunk/phase3/includes/api/ApiMove.php
> trunk/phase3/includes/api/ApiUndelete.php
Hrm, this gives me the willies... It looks really, really wrong to me to
be spreading these things around. They belong in one centralized place
-- *one* place makes the edits happen, *one* place makes the deletes
happen, etc.
If we have to call the same internal action-related hook in two
different places, we've failed utterly to factor our code properly, and
I guarantee *it will break* in the future.
The edit API definitely shouldn't get enabled until that's cleaned up
better so we've got a maintainable system...
-- brion vibber (brion @ wikimedia.org)
Any particular reason for naming contributer names in RELEASE-NOTES? If so,
I'm afraid I missed a few hundred in the past months...
Siebrand
-----Oorspronkelijk bericht-----
Van: mediawiki-cvs-bounces(a)lists.wikimedia.org
[mailto:mediawiki-cvs-bounces@lists.wikimedia.org] Namens
btongminh(a)mayflower.knams.wikimedia.org
Verzonden: zaterdag 24 mei 2008 18:37
Aan: mediawiki-cvs(a)lists.wikimedia.org
Onderwerp: [MediaWiki-CVS] SVN: [35284] trunk/phase3/RELEASE-NOTES
<snip>
-* (bug 14243) Fixed a security leak in the edit api; patch by HardDisk
+* (bug 14243) Only accept post requests in action=edit; patch by
+HardDisk
<snip>
On 23/05/2008, werdna(a)svn.wikimedia.org <werdna(a)svn.wikimedia.org> wrote:
> Revision: 35224
> Author: werdna
> Date: 2008-05-23 10:34:11 +0000 (Fri, 23 May 2008)
>
> Log Message:
> -----------
> Core changes for GlobalBlocking and TorBlock extensions, plus some core refactoring work:
> * Instead of saying 'do that' in a permissions error, actually list what the action is (drawn from the right-$1 messages). This isn't perfect - it says you don't have permission to edit pages when
> you can't edit a single page, but it's better than 'do that'.
Building messages from lego blocks is usually a bad idea and it feels
like no other languages was though about in the process. The right
messages start with a capital letter in English, and then there is the
following code:
$action_desc[0] = strtolower($action_desc[0]);
It is wrong in two ways. First it should be using proper language
specific functions in Language-class and secondly that thing should be
in the message itself ({{lcfirst:$1}}), unless you are sure every
other language uses same capitalisation rules as English does in this
case (I wouldn't count on that).
Just think about the languages that may need more complex changes than
lowercasing the first letter. I can't think of any right now, but even
in Finnish it requires that all right messages are translated using
the same infinitive verb form.
I'd like to hear from translators, if it is not possible to translate
this message properly to some languages.
--
Niklas Laxström
Hey, just to give y'all a heads-up... after a couple months of good
testing w/ the sysops & power users, we're going to widen the
CentralAuth rollout to allow everybody on Wikimedia sites to opt-in to
the system.
We're going to keep automatic migration off for now to keep the volume
down, as we may want to roll out more helper tools in response to new
issues people might have.
-- brion vibber (brion @ wikimedia.org)
On 25.05.2008 17:00:38, brion(a)svn.wikimedia.org wrote:
> Revision: 35322
> Author: brion
> Date: 2008-05-25 17:00:38 +0000 (Sun, 25 May 2008)
>
> Log Message:
> -----------
> Revert r35277 (grayed-out paging links). IMHO this just doesn't look very good.
>
> Modified Paths:
> --------------
> trunk/phase3/RELEASE-NOTES
> trunk/phase3/includes/DefaultSettings.php
> trunk/phase3/includes/Pager.php
> trunk/phase3/skins/common/shared.css
I don't mind if they aren't greyed out by default, but could we leave the css
classes in? You removed them as well.
Leon
--
Leon Weber, leon(a)leonweber.de 0x8E04D7FC
blog: https://leonweber.de/blog
jabber: leon(a)jabber.ccc.de (icq: 261067046)
--
Wer Gründe anhört, kommt in Gefahr nachzugeben. (Goethe)
> On which wiki? What is exact version of MediaWiki here? Where is a
> page with example of failing templates? Did you introduce any manual
> changes to the code? Most likely, no developer can help you without
> this information.
Unfortunately this Wiki runs in our Intranet and therefore i am unable provide you with access to it. We have got mediawiki 1.11.0 running with no manual changes to the code but some extensions installed + monobook.js / monobook.css. I wanted to dump/import the pages of that wiki to a plain install of mediawiki 1.12.0 but during that procedure some characters on some pages got lost, so some pages are even more broken than before.
So as already posted before, template expansion is sometimes done and sometimes not - without any changes happened on the respecting pages. I don't know what additional information i can give, so please ask.
regards, markus
__________________________________________________________
Gesendet von Yahoo! Mail.
Dem pfiffigeren Posteingang.
http://de.overview.mail.yahoo.com
Hi,
this behavior appears even on short pages with < 500 Words + 5 templates that only do simple html formatting.
regards, markus
----- Ursprüngliche Mail ----
Von: Nicolas Dumazet <nicdumz(a)gmail.com>
An: Wikimedia developers <wikitech-l(a)lists.wikimedia.org>
Gesendet: Sonntag, den 25. Mai 2008, 16:47:28 Uhr
Betreff: Re: [Wikitech-l] Bug Report: Template parsing
also, since r35059 (shameless self plug), some warnings are added on preview.
2008/5/25 Platonides <Platonides(a)gmail.com>:
> Markus Nissen wrote:
>> Hi List,
>> I wanted to file this bug in the bugtracker, but i never got an signup reply from this form https://bugzilla.wikimedia.org/createaccount.cgi - to sorry for posting this here and not in the bugtracker.
>>
>> I observe some very strange behavior regarding template parsing in mediawiki 1.11.0 and 1.12.0: I created some very simple Templates and they worked as expected when creating them. After some time now these templates are simply not parsed anymore in some articles. Instead {{<template name|<parameter>}} appears on the article page. I have no idea how to debug this, since this effect has already disappeared on some articles simply by doing nothing.
>>
>> Any Ideas?
>>
>> Many Thanks, Markus
>
> Perhaps you already have too many templates on that page or the page
> with the templates would be too large?
> There're checks in place to avoid template expansion on those cases (a
> warning will be inserted in a html comment).
>
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l(a)lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
--
Nicolas Dumazet — NicDumZ
pywikipedia & mediawiki
Deuxième année ENSIMAG.
06 03 88 92 29
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
__________________________________________________________
Gesendet von Yahoo! Mail.
Dem pfiffigeren Posteingang.
http://de.overview.mail.yahoo.com