On 23/05/2008, werdna(a)svn.wikimedia.org <werdna(a)svn.wikimedia.org> wrote:
> Revision: 35224
> Author: werdna
> Date: 2008-05-23 10:34:11 +0000 (Fri, 23 May 2008)
>
> Log Message:
> -----------
> Core changes for GlobalBlocking and TorBlock extensions, plus some core refactoring work:
> * Instead of saying 'do that' in a permissions error, actually list what the action is (drawn from the right-$1 messages). This isn't perfect - it says you don't have permission to edit pages when
> you can't edit a single page, but it's better than 'do that'.
Building messages from lego blocks is usually a bad idea and it feels
like no other languages was though about in the process. The right
messages start with a capital letter in English, and then there is the
following code:
$action_desc[0] = strtolower($action_desc[0]);
It is wrong in two ways. First it should be using proper language
specific functions in Language-class and secondly that thing should be
in the message itself ({{lcfirst:$1}}), unless you are sure every
other language uses same capitalisation rules as English does in this
case (I wouldn't count on that).
Just think about the languages that may need more complex changes than
lowercasing the first letter. I can't think of any right now, but even
in Finnish it requires that all right messages are translated using
the same infinitive verb form.
I'd like to hear from translators, if it is not possible to translate
this message properly to some languages.
--
Niklas Laxström