On Sun, May 25, 2008 at 7:14 PM, Brion Vibber <brion(a)wikimedia.org> wrote:
btongminh(a)svn.wikimedia.org wrote:
Log Message:
-----------
* Add wfRunHook calls where appropriate
Modified Paths:
--------------
trunk/phase3/includes/api/ApiBlock.php
trunk/phase3/includes/api/ApiDelete.php
trunk/phase3/includes/api/ApiEditPage.php
trunk/phase3/includes/api/ApiLogout.php
trunk/phase3/includes/api/ApiMove.php
trunk/phase3/includes/api/ApiUndelete.php
Hrm, this gives me the willies... It looks really, really wrong to me to
be spreading these things around. They belong in one centralized place
-- *one* place makes the edits happen, *one* place makes the deletes
happen, etc.
If we have to call the same internal action-related hook in two
different places, we've failed utterly to factor our code properly, and
I guarantee *it will break* in the future.
Also note that the 'ArticleDelete' hook is called from two places in
core. We should probably fix that as well.
Bryan