Timo and I are going to come up with a patch that can solve the same problems that these reverted changes were trying to solve, and do so without regressing the accessibility of the site. I noted that the changes broke at least two rules:
1. Don't rely on color along 2. Contrast ratio between background and foreground colors on the changed text portion of a diff is not high enough
Timo and I are coming up with a patch today.
This is not bike shedding. We are talking about colors. But it's not to do with personal preferences. It's to do with functionality and accessibility. The patch offered new functionality by rendering whitespace changes and making it easier to see a changed period or other small punctuation. The patch also violated some accessibility guidelines[1].
- Trevor
[1] http://www.mediawiki.org/wiki/User_interface_guidelines#Accessibility
On Thu, Mar 1, 2012 at 7:12 AM, Chad innocentkiller@gmail.com wrote:
On Thu, Mar 1, 2012 at 4:35 AM, Antoine Musso hashar+wmf@free.fr wrote:
As for the diff colors, we had a long discussion on r105280 as well as on IRC. It would have been great to ask around before reverting that
change,
I am not sure it was that urgent. Anyway, can you please poke Brandon Harris about it? He explained the choice of colors on r106884:
For what it's worth, there was a pretty heated discussion about this again last night on IRC--complaints came in and then Trevor voiced concern about the decisions made in 1.19 so Timo reverted. You must've been asleep ;-)
I pointed out that it would've been nice if Trevor had commented back when this was going on, and he said he honestly missed the discussion or he would've joined at the time.
Like I said on IRC yesterday: I don't care what colors we choose. At all. I *do* think there should be consensus before moving forward though, and perhaps it'd be worth writing up an RFC to get wider input and allow everyone to voice their opinions at length (bugzilla is a terrible forum for this).
As trunk stands, we've restored the status quo from 1.18 and below, so I think it's best to keep things as-is until a decision is made.
-Chad
PS: These are just my common sense suggestions, feel free to ignore them...I have no intentions of involving myself in actual debate.
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l