On Thu, Mar 1, 2012 at 4:35 AM, Antoine Musso hashar+wmf@free.fr wrote:
As for the diff colors, we had a long discussion on r105280 as well as on IRC. It would have been great to ask around before reverting that change, I am not sure it was that urgent. Anyway, can you please poke Brandon Harris about it? He explained the choice of colors on r106884:
For what it's worth, there was a pretty heated discussion about this again last night on IRC--complaints came in and then Trevor voiced concern about the decisions made in 1.19 so Timo reverted. You must've been asleep ;-)
I pointed out that it would've been nice if Trevor had commented back when this was going on, and he said he honestly missed the discussion or he would've joined at the time.
Like I said on IRC yesterday: I don't care what colors we choose. At all. I *do* think there should be consensus before moving forward though, and perhaps it'd be worth writing up an RFC to get wider input and allow everyone to voice their opinions at length (bugzilla is a terrible forum for this).
As trunk stands, we've restored the status quo from 1.18 and below, so I think it's best to keep things as-is until a decision is made.
-Chad
PS: These are just my common sense suggestions, feel free to ignore them...I have no intentions of involving myself in actual debate.