-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
btongminh@svn.wikimedia.org wrote:
// Check permissions
$errors = EmailUserForm::getPermissionsError( $params['target'] );
if ( $errors )
$this->dieUsageMsg( $errors[0] );
// Rate limiter
if( $wgUser->pingLimiter( 'emailuser' ) )
$this->dieUsageMsg( 'actionthrottledtext' );
This seems to be duplicating a couple of active checks (permissions, rate limits...), maybe a little refactoring to the backend could eliminate that?
- -- brion
wikitech-l@lists.wikimedia.org