Yesterday a friend of mine discovered and filed a bug that highlights a backwards incompatibility introduced by 1.18.
The bug is "Moved ArticleSave hook breaks backward compatibility" (https://bugzilla.wikimedia.org/32318).
I found a number of public functions in the Article class that are not directly supported in WikiPage.
To be clear, I don't know how widely those public functions are used. They may be inconsequential. It may be only my friend who is likely to run into a problem on upgrading.
So my question: is this problem worth holding back a 1.18 release while we implement any missing functionality?
Mark.
On Fri, Nov 11, 2011 at 5:50 AM, Mark A. Hershberger mhershberger@wikimedia.org wrote:
Yesterday a friend of mine discovered and filed a bug that highlights a backwards incompatibility introduced by 1.18.
The bug is "Moved ArticleSave hook breaks backward compatibility" (https://bugzilla.wikimedia.org/32318).
I found a number of public functions in the Article class that are not directly supported in WikiPage.
To be clear, I don't know how widely those public functions are used. They may be inconsequential. It may be only my friend who is likely to run into a problem on upgrading.
You would probably only run into trouble if you have custom (i.e. not in MW SVN) extensions or other custom code using those hooks. I hunted down and fixed all extensions in SVN using the no-longer-supported methods, and there weren't many of them. I think Aaron should have a big say in this seeing as he's the one that did all the WikiPage stuff, but I essentially see two options: put in some backwards compatibility hack (that we'll have to maintain forever) or accept this as a breaking change and announce it as such.
Roan
On Fri, Nov 11, 2011 at 4:06 AM, Roan Kattouw roan.kattouw@gmail.com wrote:
but I essentially see two options: put in some backwards compatibility hack (that we'll have to maintain forever) or accept this as a breaking change and announce it as such.
The latter, please.
-Chad
Why can't we pass an Article there? (note that Article has all of WikiPage functions)
Perhaps doEdit could be in Article instead of WikiPage, given that Article functions seems to be those related to the content.
Maybe it's just that I haven't understood yet the basis for the diference between a WikiPage and an Article (which doesn't seem documented either).
Platonides Platonides@gmail.com writes:
Why can't we pass an Article there? (note that Article has all of WikiPage functions)
Perhaps doEdit could be in Article instead of WikiPage, given that Article functions seems to be those related to the content.
Maybe it's just that I haven't understood yet the basis for the diference between a WikiPage and an Article (which doesn't seem documented either).
Aaron,
Could you clarify this?
Mark
Platonides Platonides@gmail.com writes:
Why can't we pass an Article there? (note that Article has all of WikiPage functions)
Perhaps doEdit could be in Article instead of WikiPage, given that Article functions seems to be those related to the content.
Maybe it's just that I haven't understood yet the basis for the diference between a WikiPage and an Article (which doesn't seem documented either).
Aaron,
Could you clarify this?
Mark
wikitech-l@lists.wikimedia.org