Hello,
I have crafted and enabled two new jobs:
* mediawiki-phpunit-hhvm * mediawiki-phpunit-zend
Which are triggered whenever a patch is proposed to the repos:
mediawiki/core mediawiki/vendor
Or the mobile related extensions:
Echo JsonConfig Mantle MobileApp MobileFrontend VisualEditor WikiGrok ZeroBanner ZeroPortal
The jobs clone all of those repositories and run the MediaWiki core extension test suite, ie:
cd tests/phpunit php phpunit.php --testsuite extensions
They are NOT run on old branches (REL1_19, REL1_22, REL1_23, REL1_24), the old jobs are.
They are run (and pass) on master and wmf branches and will on future REL branch (ie REL1_25).
They do NOT run the MediaWiki core main tests suites cause that is awfully slow. The previous jobs weren't either.
On mediawiki/core and mediawiki/vendor we still run the core tests though (mediawiki-phpunit-{hhvm,zend}).
_ / \ / | \ /__.__\
Side effect: if one deprecates a function/method in mediawiki/core and it is used by one of the extensions above, the job will fail until the extensions above have been adjusted.
I hope to add more extensions to that list. Additionally I am looking to add a command to verify whether an extension is a good candidate for inclusion.
For more context/details see:
[WikimediaMobile] Testing extensions together https://lists.wikimedia.org/pipermail/mobile-l/2014-December/008398.html
Gerrit change https://gerrit.wikimedia.org/r/#/c/180494/
RFC Task https://phabricator.wikimedia.org/T1350
The RFC itself: https://www.mediawiki.org/wiki/Requests_for_comment/Extensions_continuous_in...
On 12 January 2015 at 08:31, Antoine Musso hashar+wmf@free.fr wrote:
I have crafted and enabled two new jobs:
- mediawiki-phpunit-hhvm
- mediawiki-phpunit-zend
Which are triggered whenever a patch is proposed to the repos:
mediawiki/core mediawiki/vendor
Or the mobile related extensions:
Echo JsonConfig Mantle MobileApp MobileFrontend VisualEditor WikiGrok ZeroBanner ZeroPortal
Lovely stuff. Thank you, Antoine.
J.
On Mon, Jan 12, 2015 at 9:31 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
I have crafted and enabled two new jobs:
- mediawiki-phpunit-hhvm
- mediawiki-phpunit-zend
...
Side effect: if one deprecates a function/method in mediawiki/core and it is used by one of the extensions above, the job will fail until the extensions above have been adjusted.
This should mean fewer problems for QA to find in beta labs. I am all for that.
Win. PS. Mantle is in the process of being deprecated (see https://phabricator.wikimedia.org/T85890) so you will be able to remove that soon.
On Mon, Jan 12, 2015 at 9:07 AM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Mon, Jan 12, 2015 at 9:31 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
I have crafted and enabled two new jobs:
- mediawiki-phpunit-hhvm
- mediawiki-phpunit-zend
...
Side effect: if one deprecates a function/method in mediawiki/core and it is used by one of the extensions above, the job will fail until the extensions above have been adjusted.
This should mean fewer problems for QA to find in beta labs. I am all for that. _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Le 12/01/2015 22:00, Jon Robson a écrit :
Win.
Thanks!
PS. Mantle is in the process of being deprecated (see https://phabricator.wikimedia.org/T85890) so you will be able to remove that soon.
The problem with the job is that the list of extension is hardcoded straight in the Jenkins job config :-(
I will later on reuse the list of extensions in the make-wmf-branch script. We could have REL branches in that repo. I crafted a patch to use it but havent followed up yet.
For what it is worth the make-wmf-branch hack is:
https://gerrit.wikimedia.org/r/#/c/161225/
Le 12/01/2015 17:31, Antoine Musso a écrit :
Hello,
I have crafted and enabled two new jobs:
- mediawiki-phpunit-hhvm
- mediawiki-phpunit-zend
Which are triggered whenever a patch is proposed to the repos:
mediawiki/core mediawiki/vendor
Or the mobile related extensions:
Hello,
Today I have added the Thanks extension as well as the dependencies of the Flow extension:
AbuseFilter CheckUser ConfirmEdit Echo EventLogging SpamBlacklist
While at it, I added a function that let one inject their extension in the jobs without actually changing the hardcoded list.
Simply: - push a dummy patch for your extension - Comment in Gerrit 'check experimental'
That will run mediawiki-phpunit-zend with all the extensions PLUS the extension for which you triggered the run. If the job pass, it is a good candidate to be added to the hardcoded list of extensions.
cheers,
wikitech-l@lists.wikimedia.org