Hi guys, I'm Sohom Datta.
I recently decided to create a draft for an hypothetical extension ProtectionIndicator, which will add a protection icon on the top of every protected page. I did this primarily out of my own interest in getting familiar with the code-base of MediaWiki.
I've hosted all the code I have written (still unfinished) in this github repository http://github.com/sohomdatta1/ProtectionIndicator.
I'd like some guidance on how to implement the unfinished parts of the extension especially the integration with FlaggedRevs and the addition of a log entry to a popup ( Details are there in the readme.md of the repo) . Also any feedback on my code would also be very good.
Also, it would be great if somebody could guide me on how to make this a official extension someday.
Regards, Sohom Datta
Hi and thanks for your email (and code)! :)
On Fri, 2019-11-22 at 23:54 +0530, Sohom Datta wrote:
Hi guys, I'm Sohom Datta.
I recently decided to create a draft for an hypothetical extension ProtectionIndicator, which will add a protection icon on the top of every protected page. I did this primarily out of my own interest in getting familiar with the code-base of MediaWiki.
I've hosted all the code I have written (still unfinished) in this github repository < http://github.com/sohomdatta1/ProtectionIndicator
.
I'd like some guidance on how to implement the unfinished parts of the extension especially the integration with FlaggedRevs and the addition of a log entry to a popup ( Details are there in the readme.md of the repo) . Also any feedback on my code would also be very good.
Is this a call for potentially interested co-maintainers? Or do you have specific implementation questions to share?
Also, it would be great if somebody could guide me on how to make this a official extension someday.
Could you elaborate what "official" means, and what you expect from it?
Thanks! andre
Hi,
The first two questions were actually intended to be implementation questions, specifically on whether it is possible to implement the two features that I thought about ?
However, now that you mentioned it, it certainly would be great if some experienced contributors could co-maintain and help me with creating the extension.
Also, by official extension I mean like the extensions that have a page on the MediaWiki wiki and are hosted on Gerrit. :)
On Sat, Nov 23, 2019, 12:37 AM Andre Klapper aklapper@wikimedia.org wrote:
Hi and thanks for your email (and code)! :)
On Fri, 2019-11-22 at 23:54 +0530, Sohom Datta wrote:
Hi guys, I'm Sohom Datta.
I recently decided to create a draft for an hypothetical extension ProtectionIndicator, which will add a protection icon on the top of every protected page. I did this primarily out of my own interest in getting familiar with the code-base of MediaWiki.
I've hosted all the code I have written (still unfinished) in this github repository < http://github.com/sohomdatta1/ProtectionIndicator
.
I'd like some guidance on how to implement the unfinished parts of the extension especially the integration with FlaggedRevs and the addition
of a
log entry to a popup ( Details are there in the readme.md of the repo) . Also any feedback on my code would also be very good.
Is this a call for potentially interested co-maintainers? Or do you have specific implementation questions to share?
Also, it would be great if somebody could guide me on how to make this a official extension someday.
Could you elaborate what "official" means, and what you expect from it?
Thanks! andre -- Andre Klapper (he/him) | Bugwrangler / Developer Advocate https://blogs.gnome.org/aklapper/
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Sat, Nov 23, 2019 at 1:06 AM Sohom Datta dattasohom1@gmail.com wrote:
Hi,
The first two questions were actually intended to be implementation questions, specifically on whether it is possible to implement the two features that I thought about ?
However, now that you mentioned it, it certainly would be great if some experienced contributors could co-maintain and help me with creating the extension.
Also, by official extension I mean like the extensions that have a page on the MediaWiki wiki and are hosted on Gerrit. :)
Anyone can create a page for an extension and you can also request for your extension to be hosted on Gerrit - it helps a lot of if you are looking at localisation of the extension. Nothing official here here, however if there is something official it would probably mean the extension is used on one of the Wikimedia wikis.
On Sat, Nov 23, 2019, 12:37 AM Andre Klapper aklapper@wikimedia.org wrote:
Hi and thanks for your email (and code)! :)
On Fri, 2019-11-22 at 23:54 +0530, Sohom Datta wrote:
Hi guys, I'm Sohom Datta.
I recently decided to create a draft for an hypothetical extension ProtectionIndicator, which will add a protection icon on the top of
every
protected page. I did this primarily out of my own interest in getting familiar with the code-base of MediaWiki.
I've hosted all the code I have written (still unfinished) in this
github
repository < http://github.com/sohomdatta1/ProtectionIndicator
.
I'd like some guidance on how to implement the unfinished parts of the extension especially the integration with FlaggedRevs and the addition
of a
log entry to a popup ( Details are there in the readme.md of the repo)
.
Also any feedback on my code would also be very good.
Is this a call for potentially interested co-maintainers? Or do you have specific implementation questions to share?
Also, it would be great if somebody could guide me on how to make this
a
official extension someday.
Could you elaborate what "official" means, and what you expect from it?
Thanks! andre -- Andre Klapper (he/him) | Bugwrangler / Developer Advocate https://blogs.gnome.org/aklapper/
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Ah, okay, that's good. I'll ask for a repo once I get all the features implemented. :)
BTW, how do I get people to find/install the extension in their wikis once I get the stuff done? I forget which task it was, but I think I saw some tasks on phabricator mentioning that they needed an extension that showed protection icons. (which was part of my motivation for writing this)
Regards, Sohom Datta
On Sat, Nov 23, 2019 at 2:26 PM Nischay Nahata nischayn22@gmail.com wrote:
On Sat, Nov 23, 2019 at 1:06 AM Sohom Datta dattasohom1@gmail.com wrote:
Hi,
The first two questions were actually intended to be implementation questions, specifically on whether it is possible to implement the two features that I thought about ?
However, now that you mentioned it, it certainly would be great if some experienced contributors could co-maintain and help me with creating the extension.
Also, by official extension I mean like the extensions that have a page
on
the MediaWiki wiki and are hosted on Gerrit. :)
Anyone can create a page for an extension and you can also request for your extension to be hosted on Gerrit - it helps a lot of if you are looking at localisation of the extension. Nothing official here here, however if there is something official it would probably mean the extension is used on one of the Wikimedia wikis.
On Sat, Nov 23, 2019, 12:37 AM Andre Klapper aklapper@wikimedia.org wrote:
Hi and thanks for your email (and code)! :)
On Fri, 2019-11-22 at 23:54 +0530, Sohom Datta wrote:
Hi guys, I'm Sohom Datta.
I recently decided to create a draft for an hypothetical extension ProtectionIndicator, which will add a protection icon on the top of
every
protected page. I did this primarily out of my own interest in
getting
familiar with the code-base of MediaWiki.
I've hosted all the code I have written (still unfinished) in this
github
repository < http://github.com/sohomdatta1/ProtectionIndicator
.
I'd like some guidance on how to implement the unfinished parts of
the
extension especially the integration with FlaggedRevs and the
addition
of a
log entry to a popup ( Details are there in the readme.md of the
repo)
.
Also any feedback on my code would also be very good.
Is this a call for potentially interested co-maintainers? Or do you have specific implementation questions to share?
Also, it would be great if somebody could guide me on how to make
this
a
official extension someday.
Could you elaborate what "official" means, and what you expect from it?
Thanks! andre -- Andre Klapper (he/him) | Bugwrangler / Developer Advocate https://blogs.gnome.org/aklapper/
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi Sohom Datta, extension looks cool to me. I'll install and test, so if something is wrong I will notify you. About your question, Nischay already responded you, so my reply is same :)
Best regards, Zoran.
Hi Sohom!
On Fri, Nov 22, 2019 at 10:25 AM Sohom Datta dattasohom1@gmail.com wrote:
I'd like some guidance on how to implement the unfinished parts of the extension especially the integration with FlaggedRevs
I presume that means displaying stableness settings in a similar way to page protection? Scribunto_LuaFlaggedRevsLibrary::getStabilitySettings https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/8473c0150eaa61f965c6319e7a3ebb27ca86e0e7/scribunto/FlaggedRevs.library.php#L14 does just that (to expose it to Lua code), you can imitate what it does.
and the addition of a log entry to a popup ( Details are there in the
readme.md of the repo) .
There's LogEventList::showLogExtract amongst other things. Of course you'd have to think about caching.
Also any feedback on my code would also be very good.
Not very likely to happen in email. Probably the best way is if you make a pull request or Gerrit changeset containing all your code and ask for review on that.
Also, it would be great if somebody could guide me on how to make this a
official extension someday.
See https://www.mediawiki.org/wiki/Gerrit/New_repositories on how request a repository / create an extension page. There isn't anything particularly official about that, anyone can do it for any extension. See https://www.mediawiki.org/wiki/Continuous_integration/Entry_points on how to set up CI in Gerrit (although in practice it might be easier to just copy it from another extension).
If you want the extension to be used in Wikimedia production, see https://www.mediawiki.org/wiki/Review_queue
wikitech-l@lists.wikimedia.org