On 8/26/10 4:25 PM, Chad wrote:
On Thu, Aug 26, 2010 at 7:21 PM, Conrad
Irwin<conrad.irwin(a)gmail.com> wrote:
On 26 August 2010 16:13, Trevor
Parscal<tparscal(a)wikimedia.org> wrote:
You can also use things like function_exists()
to conditionally call
MediaWiki versions of things or native PHP stuff.
With respect, this is the wrong way to go about it. Unconditionally
remove all MediaWIki from within the library, and, if necessary,
create a wrapper that provides the extra functionality we need.
This.
The current examples of
deliberately MediaWIki free code are very good candidates for this as
they provide complex functionality that's really hard to do right yet
they have very simple interfaces.
IEContentAnaylzer is probably the best example. CDB-related stuff too.
I went ahead and moved some stuff around in r71763.
-Chad
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l Following your (chad's)
lead, I've now moved some more stuff to
includes/libs -- r72678
* JSMin -- Ryan Grove's PHP port (
http://github.com/rgrove/jsmin-php/)
of Douglas Crockford's JSMin library
(
http://www.crockford.com/javascript/jsmin.html) for removing
white-space and comments from JavaScript
* CSSJanus -- Roan Kattouw's PHP port of Google's CSSJanus library
(
http://code.google.com/p/cssjanus/) for transforming left-to-right
style-sheets into right-to-left orientation
* CSSMin -- Trevor Parscal's (my) library for CSS minification, URL
remapping and data-URL embedding
There are more Gems in MediaWiki which can likely be moved here too, but
this is at least a good start.
- Trevor