Brion Vibber wrote:
On Thu, Jul 28, 2011 at 3:09 PM, Peter Kaminski kaminski@istori.com wrote:
Do any devs have suggestions of what to do instead of checking in broken code? Or even code you're not sure about? Tips, reminders, places/ways to ask for help?
Here are a few good places to ask for assistance in:
- this mailing list
- #mediawiki channel on irc.freenode.net
- #wikimedia-dev channel on irc.freenode.net
- Code Review comment area on mediawiki.org
- bugzilla comment area on bugzilla.wikimedia.org
If you're not sure, those are *all* better places to try something out than committing directly to trunk without talking to anybody or getting any feedback.
It's a bit difficult to get comments/review in the CodeReview comments area if you haven't made the commit yet. ;-)
Sometimes the only way people can get their code reviewed is to commit it. This is an old practice. Not to beat a dead horse, but this is all related to the same "patches sit unreviewed" issue, etc.
MZMcBride