Hi all -- Please don't commit broken code to trunk; if you think your code may be broken please consider asking about it first. This is especially true if you're committing a fix for a bug that's gone back and forth over the years about how it should be solved. And it's even more true if the particular thing you're committing has been previously committed and reverted several times due to ongoing issues. Folks that have a history of having commits reverted for problems -- please start considering this. It's easier to fix your code before it goes in than after. -- brion vibber (brion @ wikimedia.org)