As I've said eslewhere, using top/bottom borders is a problem with long changes (not shown in his screenshot) and should be avoided. The original design (r112836) had this flaw, and was later fixed (r112853).
The spacing issues need attention for sure, I will look at them today.
- Trevor
On Sat, Mar 3, 2012 at 8:15 PM, Steven Walling steven.walling@gmail.comwrote:
On Thursday, March 1, 2012, Trevor Parscal tparscal@wikimedia.org wrote:
I've gone ahead and resolved bug #11374 after committing r112836.
Screenshot of new diff styles: https://bugzilla.wikimedia.org/attachment.cgi?id=10148
Brandon and I talked about the colors and the way color-blind people will perceive them - this color set provides the best cross-cultural and accessible approach so far. The design also improves contrast issues and draw attention to the changed portions better than any previous versions.
- Trevor
I *really* like this design. Much better than the current diff style, and not just for the color blind. ;-) Accentuating changed phrases more strongly and removing color where unnecessary makes it much easier to scan a diff.
Just my 2 cents,
Steven _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l