On Thu, Jul 28, 2011 at 2:49 PM, Brion Vibber brion@wikimedia.org wrote:
Please don't commit broken code to trunk; if you think your code may be broken please consider asking about it first. This is especially true if you're committing a fix for a bug that's gone back and forth over the years about how it should be solved.
+100. If a bug is really old and has the back-and-forth that Brion describes, there's probably a reason it hasn't been fixed yet. So you should be extra extra careful when trying to fix it :)
And it's even more true if the particular thing you're committing has been previously committed and reverted several times due to ongoing issues.
Yes! If you (or someone) was reverted on a feature, it does not mean you should fix the one or two minor issues that were noticed and then push it right back in again. We're not on a deadline for developing MediaWiki, so I'd encourage people to take the time to do it right. Self- review your code to make sure it all works the way you think (and claim) it does. Ask questions if you're unsure. We've got a great community of really smart developers, pretty much all of whom are more than willing to answer questions in their area(s) of expertise.
-Chad