Erwin - what you are seeing is very strange. I tried to re-create it, but you have other styles conflicting and causing problems. For instance, the use of red text for the changed text is gone int he latest code. You may also have other strange styles which may be affecting layout. Attached is how that changeset looked on my localhost.
- Trevor On Fri, Mar 2, 2012 at 2:59 PM, Erwin Dokter erwin@darcoury.nl wrote:
On 02-03-2012 23:31, Antoine Musso wrote:
Le 01/03/12 22:38, Trevor Parscal a écrit :
I've gone ahead and resolved bug #11374 after committing r112836.
Screenshot of new diff styles: https://bugzilla.wikimedia.**org/attachment.cgi?id=10148https://bugzilla.wikimedia.org/attachment.cgi?id=10148
Brandon and I talked about the colors and the way color-blind people will perceive them - this color set provides the best cross-cultural and accessible approach so far. The design also improves contrast issues and draw attention to the changed portions better than any previous versions.
I must say you rocks. This make the diff page more pleasant to use and give it a modern taste.
Thanks 8-)
I do have some issues. I like the general design, but spacing needs serious tweaking; there is too much space around the text. The outer border causes mis-alignment of text. And the borders for .diffchange overlaps text between two changes (1) (this could be solved by using top/bottom border only).
(1) http://commons.wikimedia.org/**wiki/File:Diffs-r112853.pnghttp://commons.wikimedia.org/wiki/File:Diffs-r112853.png
-- Erwin Dokter
______________________________**_________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l
