[Wikitech-l] Dealing with composer dependencies in early MediaWiki initialization

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I (with Reedy's help) recently started work on librarizing MediaWiki's IP class into a separate composer package (wikimedia/ip-utils[1]). The main motivation was so that the Parsoid PHP port could use it[2]. However, I ran into an unexpected hitch[3], as it seems we're using the IP class before the composer autoloader is even intialized. Here's the basic initialization in Setup.php: - - AutoLoader.php (MediaWiki's) - - Defines.php - - DefaultSettings.php - $wgServer = WebRequest::detectServer() - Calls IP::splitHostAndPort() - - GlobalFunctions.php - - vendor/autoload.php (composer's) My understanding is that composer's autoloader runs late so extensions registering themselves using it can add their stuff to the necessary globals. And we call WebRequest::detectServer() in DefaultSettings.php so that in LocalSettings.php people can use the value of $wgServer for other stuff. I see 3 main ways to move forward: 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking extensions that still rely on composer autoloading for initialization. 2. Set $wgServer = false or something in DefaultSettings.php, and then fill it in later in Setup.php *after* the composer autoloader has been loaded, potentially breaking anyone relying on the value of $wgServer in LocalSettings.php. 3. (status quo) not librarize code that runs before composer autoloader initialization. :( Advice/input welcome. [1] https://packagist.org/packages/wikimedia/ip-utils [2] https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717 6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46 [3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/ - -- Legoktm