On 2019-02-11 18:42, Daimona wrote:
Hi,
All patches in the codesniffer repo have a sample run against mwcore set up
in CI. As can be seen in [0], the current version is triggered 13 times by
MW core. No idea about extensions, though.
Daimona
[0]:
https://integration.wikimedia.org/ci/job/mw-tools-codesniffer-mwcore-testru…
Thanks for that link. I looked at them and submitted a change (please do
not merge it) to demonstrate what changes this would require:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/489759
In my opinion most of these changes are clear improvement or harmless,
except for the pattern in LBFactorySimple.php/LoadBalancer.php, which is
a little tricky and probably clearer in the original version.
--
Bartosz Dziewoński