-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi,
On 06/15/2018 04:42 PM, Alex Winkler wrote:
I've been wondering if it is just the
documentation being wrong or
the key being typo'd ever since 1.29, considering the extensions
dependency key is inplural I'd tend to think the key is typo'd ever
since 1.29.
Seems like a typo :(
Question would then be how to resolve this. The best
way would
probably be to deprecate the "skin" key and implement "skins" as a
key, and remove "skin" with the next major release (1.32), as I
don't think the actual behaviour should be changed mid-release.
The extension.json schema never allowed use of the singular "skin"[1],
so I wouldn't consider it a breaking change, as it never properly
worked to begin with.
And, thanks for reporting the issue - I'll follow up on reviewing
Florian's patch and make sure it gets backported to the currently
supported stable releases.
[1]
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/d
ocs/extension.schema.v2.json#57
- -- Legoktm
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlskLZkACgkQUvyOe+23
/KJC4xAAmSMI19TwXD9bKVE2czxKxY8ZN5f/QHJq0UW0kcNORuPDXwzNd41BbIVE
elLpGoMLRP/9JJw/63IC4JcThVIv7ohqZigZtXDbn+NfetVUt9f12gyZw/u4ZNa0
Oaxxr3qgldkc7S/x+I0vnaRr3sfNfgf4JbYfnzVM/GS9c+MSK97sSlkHehLrA1K4
zbrFiIvV9fFDIQjX310N2Nf0MxGf/q1/N2i8EE5wy8NXggPLgCiCmRqcePcBosnK
MxIN4SzF/cWCvCL48mircWGhs0q8mdF12xaKfkagrFPVPLumQkskSe66+pYQZZ6j
tuEctCGCoPLSyfXz6bx0d0mhKKrrPagDdfRRhQamzEONy7nykL3C+47t2Sd1m8Fd
Rq2l36CrIOOCNrbav7VPTWTfVLdVbt47C+zb2M2C9Np1OZVc0vOlwpEbgmS286e6
D0WzRtBK7uEXXp+sVjRExlzgTUlqMF3ENycOWd3fkc+qb39r3vx82wkzf/cbCdzx
czgbLanLCpu/iaI22qU0E+xAYYnbVDMvb3aeFgpBzwR3d1h1ZtH6qMMwuKUvb7BM
cmrMJmPufXfW9DRVXZ0rOBbpFyfz+aN+PRdpsxstKpFlpVy6Q5OwUg2F446D3tkl
NpPEWbFpxEhbb5K4/seRXTejIcjVJYYnzpJCWHcLpdnaMk3YyYI=
=rEWO
-----END PGP SIGNATURE-----