-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 06/15/2018 04:42 PM, Alex Winkler wrote:
I've been wondering if it is just the documentation being wrong or the key being typo'd ever since 1.29, considering the extensions dependency key is inplural I'd tend to think the key is typo'd ever since 1.29.
Seems like a typo :(
Question would then be how to resolve this. The best way would probably be to deprecate the "skin" key and implement "skins" as a key, and remove "skin" with the next major release (1.32), as I don't think the actual behaviour should be changed mid-release.
The extension.json schema never allowed use of the singular "skin"[1], so I wouldn't consider it a breaking change, as it never properly worked to begin with.
And, thanks for reporting the issue - I'll follow up on reviewing Florian's patch and make sure it gets backported to the currently supported stable releases.
[1] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/d ocs/extension.schema.v2.json#57
- -- Legoktm