That's the way Gerrit was designed. Quoting from the Gerrit documentation:
The label that the reviewer selects determines what can happen next. The +1 and -1 level are just an opinion where as the +2 and -2 levels are allowing or blocking the change. In order for a change to be accepted it must have at least one +2 and no -2 votes. Although these are numeric values, they in no way accumulate; two +1s do not equate to a +2.
The idea behind it is that developers can +1 or -1 to express their opinion, but only a -2 or +2 will actually take effect. In many code repositories, code is only ever submitted when the maintainer approves it, thus only the maintainer can actually approve or deny a change. However, since open source development involves many users, the +1/-1 functionality allows others to get their opinion in.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Sun, Dec 23, 2012 at 12:29 PM, Merlijn van Deen valhallasw@arctus.nlwrote:
On 23 December 2012 17:35, Tyler Romeo tylerromeo@gmail.com wrote:
This is a bad idea. It defies the concept of what +1 and +2 mean. Also,
+1
permissions are given to literally everybody, so any two developers could override the opinion of the repository maintainer.
I'd phrase that the other way around: the way +1 and +2 are used now defies the concept of what +1 and +2 actually mean: they are numbers, so twice +1 should be the same as +2 (after all, 1+1=2). The concept are 'looks good to me' and 'approved' (and 'no opinion' and 'do not submit'), and I would suggest to name them something else than +1 and +2 (as well was 0 and -1 -- those also imply you can just add up the opinions). Simply using 'Approved', 'OK', 'Comment' and 'Problem' is simple enough, I'd think.
Merlijn
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l