2015-09-04 1:37 GMT+02:00 Roan Kattouw <roan.kattouw(a)gmail.com>om>:
On Thu, Sep 3, 2015 at 4:15 PM, Jon Robson
<jdlrobson(a)gmail.com> wrote:
Thanks, I thought I was alone with being confused
by this e-mail. As
Jérémie correctly states we'll likely to get __less__ bugs with a more
maintained library.
Less than zero? No one has managed to find a single bug in
JavaScriptMinifier.php since 2011.
Yeah! Could I be the last person to have reported a bug in it? :D
https://phabricator.wikimedia.org/T30207
More seriously: I assume we still use JSMin+ somewhere, don't we? When
saving scripts, for validation, maybe? The issues I've encountered a
few weeks ago with gadgets that broke when migrated to ResourceLoader
because of their use of reserved identifiers were clearly related to
it (I traced them back to include/libs/jsminplus.php in core) and not
to JavaScriptMinifier. I thought it was at minification time, but it
seems I was wrong.
--
Jérémie