-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 6/26/19 11:25 PM, Tim Starling wrote:
Interesting that I wrote there: "How about this: let's set $wgServer in the installer in 1.18, and remove $wgServer autodetection from DefaultSettings.php a bit later, say in 1.20."
It was indeed 1.18, not 1.16, in which $wgServer started being set in LocalSettings.php. I added it to LocalSettingsGenerator.php here:
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90105
Anyway, it's past 1.20 so I guess that would be a good thing to do.
Thanks for the background Brian and Tim, and agreed, time to get rid of autodetection.
I wrote https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524396, and jenkins forced me to investigate that the CLI installer has not been setting $wgServer in LocalSettings, leaving wikis reliant upon autodetection.
So in the patch I added an optional --server parameter to the CLI installer, with it defaulting to http://localhost if none is provided. Does that seem acceptable enough? I'm not sure what other behavior would be sensible.
- -- Legoktm