-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi,
On 6/26/19 11:25 PM, Tim Starling wrote:
Interesting that I wrote there: "How about this:
let's set
$wgServer in the installer in 1.18, and remove $wgServer
autodetection from DefaultSettings.php a bit later, say in 1.20."
It was indeed 1.18, not 1.16, in which $wgServer started being set
in LocalSettings.php. I added it to LocalSettingsGenerator.php
here:
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90105
Anyway, it's past 1.20 so I guess that would be a good thing to
do.
Thanks for the background Brian and Tim, and agreed, time to get rid
of autodetection.
I wrote <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524396>,
and jenkins forced me to investigate that the CLI installer has not
been setting $wgServer in LocalSettings, leaving wikis reliant upon
autodetection.
So in the patch I added an optional --server parameter to the CLI
installer, with it defaulting to <http://localhost> if none is
provided. Does that seem acceptable enough? I'm not sure what other
behavior would be sensible.
- -- Legoktm
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0xUDAACgkQ8QX4EBsF
JpssUBAAoEXeWezEDKOYD7kn4FHwLk7grEnA9VTsD+jqRczC7PiHHv9NYu+Dg7KC
a5HH6aee09rkf6WS07/Pn+i4AFtBalnvPFyDvpniTAYIyoybpgtKUG8VCySFtw0Z
GH+ZHTjNngbWksWnecG2yD2QOvXJ/Y4AwtSfi5CshRlY/V7oU822Jvlnl3d/uaM4
cPDB/RPmmfENXkjNnopPRz537OBIHS10liivbrQP7Y5Q3GAykY6mgaP/6H8gFooq
fSlwlToKZhKh17KJFy2vkmHvsEoom+E2munR5TXJYoF9HKAfVX7SQ3Wua6tbk9P6
UCBBxy+6Q5GLilaYqkokHIOc1UyLHpdvZumXtqby6nlqa98IhmXKXZF18SVSqJ/N
zSsFSzx+lzwg8bGVy7BLh84HpTQsY6xDhe5HQDwA0Lfw3w5OvKN89bjFqOzr4IyS
YzRDeeuUXnP1+4DfdQ73DWyBVxhc+JefL+j3tINx5iamQvmR4clu+doM5ReCCyP+
OM7Qs8iMKaTBKHXa7KTLWDJ/+nfBaCORCsQEQi5oP8lo7x7rs9QOTobVO6KblOoD
U4BW6MPF9OLVMCk+KfzXtnhArX2TCTei2Wq2HsmJd46hA2pTOgAnAz9WdEA12cls
2seoepWMLB7JvoRjVx948IKK3F9nnTPGEkFUtyDMFGgvQ0jcxJE=
=0SNy
-----END PGP SIGNATURE-----