On Thu, Jun 10, 2010 at 9:22 AM, Roan Kattouw <roan.kattouw(a)gmail.com>wrote;wrote:
2010/6/10 Chad <innocentkiller(a)gmail.com>om>:
This is a general note to all committers, since I
keep seeing the same
question asked. Committers should never set their own revisions to
"OK" or "RESOLVED." Even if you review code, review other
people's
code and let other people review yours :)
I do believe it's acceptable to reset the status of a FIXME back to
NEW when you've addressed all the comments. It can then be reviewed
again.
In general, moving an issue out of FIXME seems like the right thing to do
for issues that the original developer thinks have been addressed,
since "fixme" is implicitly assigned to the original committer.
I was going to chime in and say that "new" seems like the right state to go
into, but what about the (very common) case where a later checkin fixes the
original "fixme"? Can't the committer put the original checkin in
"resolved", and redirect any further discussion to the followup checkin
(which should remain "new")?
The only time it seems like a checkin should go back into "new" state is
when the committer stands by the original commit, and has provided further
rationale for it in the comments.
Rob