Ashar Voultoiz wrote:
On 06/12/10 05:56, MZMcBride wrote:
I filed bug 26259, "MediaWiki bloated with
test suites":
https://bugzilla.wikimedia.org/show_bug.cgi?id=26259
RobLa asked me to send an e-mail to wikitech-l about this bug. It's my view
that checking out MediaWiki from SVN should not include files that most
users do not need or want. These test suites seem to fit perfectly within
this category.
I have at least two objections :
- I want to be able to commit a bug fix + associated tests in one
revision without having to fetch the whole phase3 tree. It is much
easier to track and phase3 has many stuff I do not care about.
I don't commit to Wikimedia's SVN repo, so I won't comment on this.
- Users fetching from SVN are most probably
interested in development
and will *require* the test suites. Regular user use the tarballs which
can be build without the tests suite though.
I don't think it's reasonable to say that most users downloading from SVN
are interested in development, though some certainly are. SVN is convenient
for installations and upgrades. That's certainly why I use it. Even if we
could say that most users downloading from SVN are interested in
development, I don't see how that extends to saying that test suites are
required for development. You've lost me.
The maintenance directory has maintenance tools in it. I don't think test
suites fall within the category of "maintenance." Like large artwork files,
these seem to be "development" tools that shouldn't be downloaded with
every
phase3 checkout.
Can't you just ignore the test suites ?
Sure, and I do. But I don't imagine that this "tests" directory will get
any
smaller with time. I don't really want to see MediaWiki get more bloated
over time with files that very few people will want or need. If that applies
to other parts of phase3 as well, those ought to be examined and considered
in separate bugs and threads (the "math" directory is a prime target, for
example).
I do not care about squid support or
utf-normalisation. Should they get
moved out of trunk as well?
Perhaps, but that's an issue for a different bug and a different thread. :-)
MZMcBride