On 12/20/05, Jonathan Leybovich
<jleybov(a)yahoo.com> wrote:
Ævar Arnfjörð Bjarmason <avarab@...>
writes:
Magnus's Rewiew extension is just that, and it
doesn't make sense to
make special considerations for extension in the main code by
definition. If extensions want something from the main codebase their
authors can add hooks to the main code and modify things with those
hooks.
But this "extension" already has its own table in the data model!
Granted the
review/validate feature can be coded to capture different data than it does now,
but the presence of a VALIDATE table in the data model firmly entrenches the
notion that pages are validateable within the Mediawiki "ontology". It thus
shouldn't be bad design to recognize and control this notion elsewhere in the
datamodel.
The only reason why there's a validate table in the main distribution
is because Review used to be in the main code, the database definition
will presumably be moved to the extensions module along with the rest
in time, Magnus?
I thought about it, but then I realized that removing a table definition
from the main distribution just to make people insert *the very same
definition* from the extension manually (AFAIK, there's no way to do
this automatically?) seems like ... well, insanity ;-)
Clean code is one thing, but what harm does that table do in the main
distribution?
Magnus