I've had patchsets that I submitted in August and they still haven't been merged. For example, the account creation API, which has actually been approved, but never merged.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Wed, Dec 19, 2012 at 1:30 PM, Sumana Harihareswara <sumanah@wikimedia.org
wrote:
On 12/19/2012 07:24 AM, vitalif@yourcmc.ru wrote:
Antoine Musso писал 2012-12-19 16:19:
Le 19/12/12 11:57, vitalif@yourcmc.ru wrote:
Hello!
28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them ("uploaded patch set 2"), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function?
And the changes are:
https://gerrit.wikimedia.org/r/#/c/39369/ "add a dependency on mediawiki.legacy.wikibits."
https://gerrit.wikimedia.org/r/#/c/25629/ "Fix a bug: drafts didn't show up when creating new pages"
https://gerrit.wikimedia.org/r/#/c/25628/ "Always display user's drafts on the edit form"
https://gerrit.wikimedia.org/r/#/c/25627/ "Fix for PHP 5.4: add & to function prototype"
Yes, exactly! I've just added the first one ("added dependency.."). Others are older..
Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews
-- Sumana Harihareswara Engineering Community Manager Wikimedia Foundation
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l