On 12/19/2012 07:24 AM, vitalif(a)yourcmc.ru wrote: Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews -- Sumana Harihareswara Engineering Community Manager Wikimedia Foundation

On 12/19/2012 02:41 PM, Tyler Romeo wrote: Which one are you referring to, https://gerrit.wikimedia.org/r/#/c/18127/ ? On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? Matt Flaschen

Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been approved, i.e., +2 on CR. But it's yet to have been merged. At the very least, its dependency has been merged. I'm not in a humongous rush or anything, I'm just pointing out that sometimes you really just have to wait it out. ;) *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo(a)gmail.com On Wed, Dec 19, 2012 at 4:58 PM, Matma Rex <matma.rex(a)gmail.com> wrote:

On 12/19/2012 04:58 PM, Matma Rex wrote: It turns out Parent5446 is his actual username. But if I didn't know better, it looks like some auto-generated gerrit ID. :) Matt Flaschen

On Wed, 2012-12-19 at 13:30 -0500, Sumana Harihareswara wrote: Does Gerrit support setting "default CCs" for certain code areas (projects, subfolders etc)? Letting new contributors search manually for a patch reviewer feels as wrong as letting new bug reporters search for an assignee or somebody to comment on their report. andre -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/

On 20 December 2012 13:35, Andre Klapper <aklapper(a)wikimedia.org> wrote: It's possible to do it the other way around - people can /subscribe/ to a project via https://gerrit.wikimedia.org/r/#/settings/projects and receive e-mails when new patchsets are uploaded. I don't think this adds people to the reviewers list, but at least people get notified.