Simetrical wrote:
That was me borking up in one of my first commits,
last night. I
unhardcoded the section edit link style and moved it to stylesheets,
but didn't bump the stylesheet number, so the old cached versions were
being used, resulting in no style for the edit links.
Brion bumped the numbers up on Monobook and then resynchronized, so
this should be fixed in Monobook now (it is for me, anyway). I just
bumped up the numbers for all the other skins, so those will be fixed
in the next resync. (Actually, I missed at least one, but Brion just
bumped that up, so it should all be good.)
I've now centralized this in a single global config var, $wgStyleVersion. Bump
this whenever making changes to .css or .js files in the core distribution. When
adding new such files, don't forget to include "?$wgStyleVersion" on the
link.
For those not familiar with the technique, this is an easy way to make style
updates cache-friendly. Newly rendered pages which depend on the new styles will
include the links with the bumped number -- the query string is ignored by the
server (which is reading a static file) but the client will consider it a new
URL and so pull the file fresh instead of using the previous cached version.
We had been using this haphazardly; now just bumping that one var in
DefaultSettings.php will bump all imported styles consistently, so it's harder
to forget something.
Note that there can still be problems sometimes with old cached pages and new
styles/scripts, so it's best for new .css/.js file versions to remain reasonably
compatible with older generated HTML.
-- brion vibber (brion @
pobox.com)