On Fri, Aug 31, 2012 at 7:01 AM, Daniel Werner
<daniel.werner(a)wikimedia.de> wrote:
Hi everyone,
Started poking on parser tests lately and found myself riddled after a
while.
It seems like when running parser test files with phpunit.php they follow
different rules as when running them with parserTests.php.
If I observed this correctly, phpunit.php collects all articles to be
created with "!!article", creates them, and then it runs tests. With
parserTests.php on the other hand everything is executed in the order it is
defined. In some tests it can be important whether a article already exists
or not.
There might be other behavioral differences here as well. The whole thing
seems incredibly odd to me since there is also some redundant code and the
initial globals set up in ParserTest::setupGlobals() are slightly different
from globals set up in NewParserTest::setupGlobals().
If there is no good reason against this, both classes, ParserTest and
NewParserTest should be reduced to one, or at least one base
class/interface. The goal should be that when running phpunit.php parser
tests behave exactly like running parserTests.php
Already created a bug report for this as well, it just didn't get any
attention so far, so I try it here:
https://bugzilla.wikimedia.org/show_bug.cgi?id=39473
I would very much appreciate if anyone could explain to me why there are
both of these files and why we maintain (more or less) a whole bunch of
redundant code for those tests.
Cheers,
Daniel
--
Daniel Werner
Software Engineer
Wikimedia Deutschland e.V. | NEU: Obentrautstr. 72 | 10963 Berlin
Tel. (030) 219 158 26-0
http://wikimedia.de
Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/681/51985.
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
I don't know why it is like it is, but I have noticed that the parser
tests I wrote for DynamicPageList (Wikimedia) only work when run from
parserTests.php and not when run from phpunit. It would be awesome if
they behaved the same.
--bawolff