Thanks Max. Questions and comments below:
== Casualties ==
* Max's liver.
:(
== Conclusions ==
* Our code review practices are lax, including merging hairy patches
without testing and self-merges.
Is there a way to improve how code review is done such that appropriate
testing would have happened in advance? I'm not referring to this specific
case so much as the more general case of making sure that appropriate tests
are written and done. Is there a "process owner" for code review who might
take a look at this situation and see what can be learned from it for the
general code review process?
Pine
On Wed, Aug 10, 2016 at 11:53 AM, Max Semenik <maxsem.wiki(a)gmail.com> wrote:
On Wed, Aug 10, 2016 at 11:49 AM, Max Semenik
<maxsem.wiki(a)gmail.com>
wrote:
TLDR: migration of 2 extensions to
wfLoadExtension() resulted in
problems,
Logstash wasn't displaying them.
Posted on Wikitech:
https://wikitech.wikimedia.org/wiki/Incident_documentation/20160809-
MediaWiki
--
Best regards,
Max Semenik ([[User:MaxSem]])
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l