Roan Kattouw <roan.kattouw(a)gmail.com> writes:
In the preparations for the 1.17 release I've seen
lots of commits
that were several months old and only got reviewed because we decided
to work on a release. Ideally, every commit would be reviewed within a
few days of being committed, so the committer can still reasonably be
expected to fix any issues with it.
Right. And while I think your suggestion of assigning 7 developers a
day to do reviews could work, what if we divide the code into different
areas? From looking at the sub-directories under includes/ I would
suggest a different person assigned to API, Parser, Uploads, DB,
Installer, ResourceLoader, Templates, Specials, and probably a couple
assigned to “Everything Else”.
The advantage to this, instead of having everyone manage certain days is
that it becomes a smaller, semi-daily activity instead of a larger,
once-a-week activity. My hope is that this would be more likely to get
done on a regular basis.
Side note: I'd like to encourage code reviewers to see this as an
opportunity to work with less experienced developers. We've burdened
some of our most knowledgeable and productive developers with code
review. At least some of this work could be shifted to less experienced
developers. More on that in a bit.
--
Mark A. Hershberger
Bugmeister
Wikimedia Foundation
mhershberger(a)wikimedia.org
717.271.1084