-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Uwe Baumbach wrote:
Hi core developers...,
Looking at method preload (Article.php) you can see that <includeonly> tags will be swept.
There is no "preload" method in Article.php.
Do you mean getPreloadedText() in EditPage?
Is it by mischance or by consciously decision that <noinclude>...</noinclude> parts remain?
Sounds normal to me; you either keep the parts for includes or the parts that aren't for includes.
<includeonly> -> when not including, remove this <onlyinclude> -> when including, remove anything outside this <noinclude> -> when including, remove this
However the code that's there doesn't make sense to me; it appears to be removing only the actual <includeonly> and </includeonly> start and end tags, not their content.
Would it be reasonable to add this $text = preg_replace( '/<noinclude>.*?</noinclude>/s', '', $text ); into the main source code branch?
Wouldn't that lead to a confusing mix of both?
- -- brion vibber (brion @ pobox.com / brion @ wikimedia.org)