preload method of class Article

List overview All Threads
Download

newer

older

multiple wikis, single MediaWiki...

template creation

Uwe Baumbach

14 Mar 2007 14 Mar '07

4:30 p.m.

Hi core developers..., Looking at method preload (Article.php) you can see that <includeonly> tags will be swept. Is it by mischance or by consciously decision that <noinclude>...</noinclude> parts remain? Since we do not want to hack the original source code and hooks are not provided her - so: Would it be reasonable to add this $text = preg_replace( '/<noinclude>.*?<\/noinclude>/s', '', $text ); into the main source code branch? Greetings. -- Uwe (Baumbach) U.Baumbach(a)web.de _____________________________________________________________________ Der WEB.DE SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! http://smartsurfer.web.de/?mc=100071&distributionid=000000000066

Show replies by date

Brion Vibber

14 Mar 14 Mar

5:37 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Uwe Baumbach wrote:

...

Hi core developers..., Looking at method preload (Article.php) you can see that <includeonly> tags will be swept.

There is no "preload" method in Article.php. Do you mean getPreloadedText() in EditPage?

...

Is it by mischance or by consciously decision that <noinclude>...</noinclude> parts remain?

Sounds normal to me; you either keep the parts for includes or the parts that aren't for includes. <includeonly> -> when not including, remove this <onlyinclude> -> when including, remove anything outside this <noinclude> -> when including, remove this However the code that's there doesn't make sense to me; it appears to be removing only the actual <includeonly> and </includeonly> start and end tags, not their content.

...

Would it be reasonable to add this $text = preg_replace( '/<noinclude>.*?<\/noinclude>/s', '', $text ); into the main source code branch?

Wouldn't that lead to a confusing mix of both? - -- brion vibber (brion @ pobox.com / brion @ wikimedia.org)

...PGP SIGNATURE...

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF+DLDwRnhpk1wk44RAlSCAJ42o5vQX3VWiL5zHM00jDI3P4GFhACfWUgA TTJa0B57uUjAPeTm5frJNWQ= =7whp -----END PGP SIGNATURE-----

christoph.huesler＠css.ch

16 Mar 16 Mar

12:32 p.m.

New subject: Antwort: Re: preload method of class Article

brion wrote:

...

<includeonly> -> when not including, remove this <onlyinclude> -> when including, remove anything outside this <noinclude> -> when including, remove this

...

[...]

...

Wouldn't that lead to a confusing mix of both?

Well... i'm already confused :P -- chris

Jim Hu

1:49 p.m.

New subject: Antwort: Re: preload method of class Article

Me too. Let me see if I can get it right. On Mar 16, 2007, at 8:32 AM, christoph.huesler(a)css.ch wrote:

...

brion wrote: > <includeonly> -> when not including, remove this

Shows up when the page is included in another but not when viewed under its own title? Page Foo abc<includeonly>def</includeonly>ghi Views as abcghi Page Bar {{:Foo}} Views as def

...

> <onlyinclude> -> when including, remove anything outside this > <noinclude> -> when including, remove this

Are these the same? Page Foo <noinclude>abc</noinclude>def<noinclude>ghi</noinclude> abc<onlyinclude>def</onlyinclude>ghi View both as abcdefghi Page Bar {{:Foo}} Views as def

...

[...]

Wouldn't that lead to a confusing mix of both?

Well... i'm already confused :P -- chris _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l

===================================== Jim Hu Associate Professor Dept. of Biochemistry and Biophysics 2128 TAMU Texas A&M Univ. College Station, TX 77843-2128 979-862-4054

Jim Wilson

4:20 p.m.

New subject: Antwort: Re: preload method of class Article

...

Are these the same? Page Foo <noinclude>abc</noinclude>def<noinclude>ghi</noinclude> abc<onlyinclude>def</onlyinclude>ghi

No. My understanding is that these will render respectively (when viewed normally) as: abcdefghi abcghi And will both appear transcluded as: def -- Jim On 3/16/07, Jim Hu <jimhu(a)tamu.edu> wrote:

...

Me too. Let me see if I can get it right. On Mar 16, 2007, at 8:32 AM, christoph.huesler(a)css.ch wrote:

brion wrote: > <includeonly> -> when not including, remove this

Shows up when the page is included in another but not when viewed under its own title? Page Foo abc<includeonly>def</includeonly>ghi Views as abcghi Page Bar {{:Foo}} Views as def

> <onlyinclude> -> when including, remove anything outside this > <noinclude> -> when including, remove this

Are these the same? Page Foo <noinclude>abc</noinclude>def<noinclude>ghi</noinclude> abc<onlyinclude>def</onlyinclude>ghi View both as abcdefghi Page Bar {{:Foo}} Views as def

[...]

Wouldn't that lead to a confusing mix of both?

===================================== Jim Hu Associate Professor Dept. of Biochemistry and Biophysics 2128 TAMU Texas A&M Univ. College Station, TX 77843-2128 979-862-4054 _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l

Jim Wilson

4:21 p.m.

New subject: Antwort: Re: preload method of class Article

Disregard - I think they're the same :) (Misread <onlyinclude> - teaches me to test before posting) -- Jim On 3/16/07, Jim Wilson <wilson.jim.r(a)gmail.com> wrote:

...

Are these the same? Page Foo <noinclude>abc</noinclude>def<noinclude>ghi</noinclude> abc<onlyinclude>def</onlyinclude>ghi

No. My understanding is that these will render respectively (when viewed normally) as: abcdefghi abcghi And will both appear transcluded as: def -- Jim On 3/16/07, Jim Hu <jimhu(a)tamu.edu> wrote:

Me too. Let me see if I can get it right. On Mar 16, 2007, at 8:32 AM, christoph.huesler(a)css.ch wrote:

brion wrote: > <includeonly> -> when not including, remove this

Shows up when the page is included in another but not when viewed under its own title? Page Foo abc<includeonly>def</includeonly>ghi Views as abcghi Page Bar {{:Foo}} Views as def

> <onlyinclude> -> when including, remove anything outside this > <noinclude> -> when including, remove this

Are these the same? Page Foo <noinclude>abc</noinclude>def<noinclude>ghi</noinclude> abc<onlyinclude>def</onlyinclude>ghi View both as abcdefghi Page Bar {{:Foo}} Views as def

[...]

Wouldn't that lead to a confusing mix of both?

6288

days inactive

6290

days old

wikitech-l@lists.wikimedia.org

Manage subscription

5 comments

5 participants

tags (0)

participants (5)

Brion Vibber
christoph.huesler＠css.ch
Jim Hu
Jim Wilson
Uwe Baumbach