Wikitech-l January 2008

wikitech-l@lists.wikimedia.org

105 participants
121 discussions

Fwd: (in reply to [MediaWiki-CVS] SVN: [29380] trunk/extensions)
by Huji 15 Jan '08

15 Jan '08

I asked Paul to take care of the issue himself, and he did well. See below: ---------- Forwarded message ---------- From: Paul Grinberg <gri6507(a)yahoo.com> Date: Jan 15, 2008 3:41 AM Subject: RE: License for Javascript Calendar code To: Matt Kruse <matt(a)mattkruse.com> Cc: huji.huji(a)gmail.com Matt, Thank you for the response. I will update the license in MediaWiki SVN. Paul. --- Matt Kruse <matt(a)mattkruse.com> wrote: > Hi, > > You can use this new disclaimer, which I now include with all my new > libraries: > > * Copyright (c) 2008 Matt Kruse (javascripttoolbox.com) > * Dual licensed under the MIT and GPL licenses. > > Hope that helps! > > Matt > > ...

2 1

UploadComplete hook call in SpecialUpload
by Travis Derouin 15 Jan '08

15 Jan '08

Would it make sense to change the calling of this hook from: $img = null; // @todo: added to avoid passing a ref to null - should this be defined somewhere? wfRunHooks( 'UploadComplete', array( &$img ) ); to wfRunHooks( 'UploadComplete', array( &$this ) ); This would pass in the UploadForm which has a lot of useful variables for callers to use. It would help the MultiUpload extension I've written so it can show a thumbnail of the successfully uploaded file

2 1

Re: [Wikitech-l] [MediaWiki-CVS] SVN: [29725] trunk/phase3/includes
by Simetrical 14 Jan '08

14 Jan '08

On 1/14/08, midom(a)svn.wikimedia.org <midom(a)svn.wikimedia.org> wrote: > * Shortcutted Title::userCanRead() for public wikis > . . . > public function userCanRead() { > - global $wgUser; > - > + global $wgUser, $wgGroupPermissions; > + > + # Shortcut for public wikis, allows skipping quite a bit of code path > + if ($wgGroupPermissions['*']['read']) > + return true; > + > $result = null; > wfRunHooks( 'userCan', array( &$this, &$wgUser, 'read', &$result ) ); > if ( $result !== null ) { Shouldn't the check go *after* the hook execution?

3 2

Re: [Wikitech-l] [MediaWiki-CVS] SVN: [29444] trunk
by Simetrical 14 Jan '08

14 Jan '08

On 1/8/08, vasilievvv(a)svn.wikimedia.org <vasilievvv(a)svn.wikimedia.org> wrote: > Log Message: > ----------- > * Add exception hooks to output pretty messages > . . . > - $wgOut->addHTML( $this->getHTML() ); > + if( $hookResult = $this->runHooks( get_class( $this ) ) ) { > + $wgOut->addHTML( $hookResult ); > + } else { > + $wgOut->addHTML( $this->getHTML() ); > + } Is completely replacing all output the right way to go about generating pretty error messages? Your example more or less copy-pastes the HTML from MonoBook.php, but incompletely, which isn't good for anyone -- especially not those using non-Monobook skins. If we're going to say it should just be left ugly, okay, but if it's to be made pretty, it should use skins properly, IMO. It shouldn't just output prettier hardcoded HTML, which will look just as ugly in the context of a totally different skin and be more confusing. People expect ugly error messages, but they don't expect error messages that are pretty but in a totally different way from the rest of the site. :)

4 5

Quick question
by Andrew Cates 14 Jan '08

14 Jan '08

So does anyone know why the Wikimedia Foundation site has "nofollow" on its external links too? I know on en we have given up trying to claim our content is reliable but given http://wikimediafoundation.org/wiki is approved log in only, you would have thought we might be bold and hope the quality was good enough? BozMo

2 1

How to make a local Wikipedia copy work?
by Johann Petrak 14 Jan '08

14 Jan '08

I have downloaded a enwiki dump and imported into the local database tables as described in http://meta.wikimedia.org/wiki/Data_dumps http://www.mediawiki.org/wiki/Manual:System_administration#Getting_the_data However, I am still not sure what else is necessary or needed to get the local Wikipedia installation running. For example, I have also downloaded the files -categorylinks.sql -interwiki.sql -langlinks.sql -redirect.sql -templatelinks.sql and imported them into the local tables. Is there anything else needed to be imported or run? For examples, templates are still not processed/shown correctly in my local copy -- instead the pages seem the show parts of the template source and are oddly formatted. Cheers, Johann _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l

4 5

Download Vietnamese Version?
by sothsegger＠comcast.net 14 Jan '08

14 Jan '08

My wife and I are taking a One-Laptop-Per-Child computer to a girl in a remote village in Viet Nam. The village has no internet connection. So we would like to download your Vietnamese version and install it on the laptop. Is that possible? Dan Embree

3 2

Re: [Wikitech-l] [MediaWiki-CVS] SVN: [29539] trunk/phase3
by Simetrical 13 Jan '08

13 Jan '08

On 1/10/08, amidaniel(a)svn.wikimedia.org <amidaniel(a)svn.wikimedia.org> wrote: > - $bot = $wgUser->isAllowed( 'bot' ) || ( $flags & EDIT_FORCE_BOT ); > + $bot = ( $wgUser->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0 ) || ( $flags & EDIT_FORCE_BOT ); > ... > - 'rc_bot' => $user->isAllowed( 'bot' ) ? 1 : 0, > + 'rc_bot' => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0, > ... > - 'rc_bot' => $user->isAllowed( 'bot' ) ? 1 : 0, > + 'rc_bot' => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0, Am I missing something, or are these ternary operators all equivalent to: $(wgU|u)ser->isAllowed( 'bot' ) && $wgRequest->getBool( 'bot', true ) ?

2 2

Re: [Wikitech-l] [MediaWiki-CVS] SVN: [29702] trunk/extensions/Oversight/HideRevision.php
by Roan Kattouw 13 Jan '08

13 Jan '08

grondin(a)svn.wikimedia.org schreef: > Revision: 29702 > Author: grondin > Date: 2008-01-13 20:25:23 +0000 (Sun, 13 Jan 2008) > > Log Message: > ----------- > Fixed bug for loading internationalization messages > I don't know exactly what's being fixed here, but the entire point of all those separate wfLoadExtensionMessages() call was not to load messages unless it's really necessary (this has been done to a lot of extensions lately). Your fix undoes this optimization. Roan Kattouw (Catrope)

2 2

Re: [Wikitech-l] [MediaWiki-CVS] SVN: [29682] trunk/phase3/includes/User.php
by Rotem Liss 13 Jan '08

13 Jan '08

tstarling(a)svn.wikimedia.org wrote: > Revision: 29682 > Author: tstarling > Date: 2008-01-13 03:47:07 +0000 (Sun, 13 Jan 2008) > > Log Message: > ----------- > Revert r29671, it was based on a misunderstanding of the purpose of the LoggedOut cookie. The LoggedOut cookie is there to suppress the client-side cache, not the server-side cache. It prevents privately cached logged-in pages from being displayed after the user logs out. Feel free to special-case it in squid if you're worried about the server-side cache hit ratio, but note that IMS requests would need special handling. > > * Credential data in the session is destroyed, so the session is harmless. But it is still useful for abuse tracking (logout/login sequences) and similar analysis. > * Not much point in removing the username persistence feature if you can't improve the squid cache hit ratio, which was obviously your goal. > Users may want to prevent their user name from appearing in the login box (or in a cookie, anyway), in public places or anywhere. The UserName cookie should be deleted when logging out. I think the LoggedOut cookie and the session are harmless, though.

3 2

← Newer
1
...
5
6
7
8
9
10
11
12
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Wikitech-l January 2008