I have submitted patches in the past and others have complained about
the format I use in the code. Since I have a glaucome-caused visual
defect that has me preferring lots of whitespace, I tend away from the
generic K-R style in preference to something a bit more open.
I wonder if it isn't possible to simply have all patches and additions
to SVN run through a code formatter/prettifier to get it into the format
that most seem to prefer? I suspect that it must be done _after_
merging (otherwise the code prettifier wouldn't have a clue what to do).
That would provide a uniform standard when the code is taken out of
SVN and allow for "alien" formats for others.
Mike
On 04/10/2007, catrope(a)svn.wikimedia.org <catrope(a)svn.wikimedia.org> wrote:
> Revision: 26415
> Author: catrope
> Date: 2007-10-04 20:58:36 +0000 (Thu, 04 Oct 2007)
>
> Log Message:
> -----------
> eol-style=native for the redircite extension
Please can *all committers* remember to set up Subversion
auto-properties on eligible files? Cleaning up line endings wastes
time.
Details available on http://www.mediawiki.org/wiki/Subversion/auto-props.
Rob Church
If someone feels like it, the extension / branch LiquidThreads is in
need of proper internationalization code. I've made a small start, but
there are still quite a few hardcoded strings. Generally it's very
simple:
- Replace hardcoded strings with calls for wfMsg('lqt_some_key_name')
- Add lqt_some_key_name and string(s) to extensions/LqtI18N.php
- If there are variables, you can use $1 .. $n in the string, and pass
them after the key name to wfMsg.
To check out the extension, do a
svn checkout http://svn.wikimedia.org/svnroot/mediawiki/branches/liquidthreads
and see README-liquidthreads for setup instrutions.
Help is appreciated.
--
Toward Peace, Love & Progress:
Erik
DISCLAIMER: This message does not represent an official position of
the Wikimedia Foundation or its Board of Trustees.
An automated run of parserTests.php showed the following failures:
This is MediaWiki version 1.12alpha (r26389).
Reading tests from "maintenance/parserTests.txt"...
Reading tests from "extensions/Cite/citeParserTests.txt"...
Reading tests from "extensions/Poem/poemParserTests.txt"...
Reading tests from "extensions/LabeledSectionTransclusion/lstParserTests.txt"...
17 still FAILING test(s) :(
* URL-encoding in URL functions (single parameter) [Has never passed]
* URL-encoding in URL functions (multiple parameters) [Has never passed]
* Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html) [Has never passed]
* Link containing double-single-quotes '' (bug 4598) [Has never passed]
* message transform: <noinclude> in transcluded template (bug 4926) [Has never passed]
* message transform: <onlyinclude> in transcluded template (bug 4926) [Has never passed]
* BUG 1887, part 2: A <math> with a thumbnail- math enabled [Has never passed]
* HTML bullet list, unclosed tags (bug 5497) [Has never passed]
* HTML ordered list, unclosed tags (bug 5497) [Has never passed]
* HTML nested bullet list, open tags (bug 5497) [Has never passed]
* HTML nested ordered list, open tags (bug 5497) [Has never passed]
* Inline HTML vs wiki block nesting [Has never passed]
* Mixing markup for italics and bold [Has never passed]
* dt/dd/dl test [Has never passed]
* Images with the "|" character in the comment [Has never passed]
* Parents of subpages, two levels up, without trailing slash or name. [Has never passed]
* Parents of subpages, two levels up, with lots of extra trailing slashes. [Has never passed]
Passed 527 of 544 tests (96.88%)... 17 tests failed!
An automated run of parserTests.php showed the following failures:
This is MediaWiki version 1.12alpha (r26354).
Reading tests from "maintenance/parserTests.txt"...
Reading tests from "extensions/Cite/citeParserTests.txt"...
Reading tests from "extensions/Poem/poemParserTests.txt"...
Reading tests from "extensions/LabeledSectionTransclusion/lstParserTests.txt"...
17 still FAILING test(s) :(
* URL-encoding in URL functions (single parameter) [Has never passed]
* URL-encoding in URL functions (multiple parameters) [Has never passed]
* Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html) [Has never passed]
* Link containing double-single-quotes '' (bug 4598) [Has never passed]
* message transform: <noinclude> in transcluded template (bug 4926) [Has never passed]
* message transform: <onlyinclude> in transcluded template (bug 4926) [Has never passed]
* BUG 1887, part 2: A <math> with a thumbnail- math enabled [Has never passed]
* HTML bullet list, unclosed tags (bug 5497) [Has never passed]
* HTML ordered list, unclosed tags (bug 5497) [Has never passed]
* HTML nested bullet list, open tags (bug 5497) [Has never passed]
* HTML nested ordered list, open tags (bug 5497) [Has never passed]
* Inline HTML vs wiki block nesting [Has never passed]
* Mixing markup for italics and bold [Has never passed]
* dt/dd/dl test [Has never passed]
* Images with the "|" character in the comment [Has never passed]
* Parents of subpages, two levels up, without trailing slash or name. [Has never passed]
* Parents of subpages, two levels up, with lots of extra trailing slashes. [Has never passed]
Passed 527 of 544 tests (96.88%)... 17 tests failed!
Hi,
I am trying to find a way to autologin users who register or login to
Mediawiki to also be registered and logged into another application's
user database in order to save them a second registration. I have
found many extensions that do it the other way round (from another
application automatically into MW), but not this case. Does anyone
have a suggestion on how to go about doing this?
The second application is a php based web app with its own, very
simple security model. It just needs username, password and email
address.
Some use cases:
#1
1. New user fills in registration page in MW
2. a) MW registers user in MW database
2. b) MW registers user in second, external (but local) database
3. User is logged into MW and logged into external application
#2
1. Existing user logs into MW
2. MW automatically logs user into other application
#3
1. User logs out of MW
2. MW logs out user from other application
#4
1. User changes password in MW
2. MW updates password in other database
(there could be a variation of this use case if users use 'forgot
password' and similar)
Thanks,
Andi
Hi,
I'm trying to extend QueryPage into an extension, which should be
pretty simple. If I declare the class in a new file located in the
extensions subdirectory to extend QueryPage:
class BuddyPage extends PageQueryPage {
}
I get:
Fatal error: Class 'PageQueryPage' not found in
/var/www/html/mediawiki-1.11.0/extensions/BuddyPage.php on line 21
But if I include QueryPage.php:
require_once('QueryPage.php');
I get the error:
Fatal error: Call to undefined function wfRunHooks() in
/var/www/html/mediawiki-1.11.0/includes/QueryPage.php on line 46
Seems like a bit of a chicken and egg problem, any ideas?
Travis
On 02/10/2007, robchurch(a)svn.wikimedia.org <robchurch(a)svn.wikimedia.org> wrote:
> Revision: 26332
> Author: robchurch
> Date: 2007-10-02 22:43:28 +0000 (Tue, 02 Oct 2007)
>
> Log Message:
> -----------
> Spacing
You just couldn't let my first proper commit go by without finding
something wrong with it, could you? ;)