When proofreading pages in it.wikisource, we are plagued by this message:
Change not allowed - You are not allowed to change the proofreading status of this page
Going back to failed page, we noted that: 1. quality level is reverted to 1; 2. anything stored into header has been lost; 3. proofreadpage_username is set to an empty string
The bug is impredictable, it occurs with different frequencies to different users when trying to edit different pages. Something wrong seems to occur when building the page code merging variables, header, body and footer contents. We wrote an "emergency fixing script" but it can only be called after the edit turns out to be wrong.
Is something similar happening into any other wikisource project? Can you give us a link to understand what's happening? And - where can we find the js script which merges variables-header-body-footer into page code to send it to the server?
Alex
Hi! This bug is very strange. Its looks like it append only on italian Wikisource, so I think that one of your common.js script of gadget cause the bug. This bug is impradicable it might be caused by a change of execution order of two script, by example your common.js (or a gadget) and scripts of ProofreadPage.
ProofreadPage init header, footer and quality contents from the content of the main textbox in its JavaScript so you mustn't supposed that the header and footer content is removed from the textbox when you write a script because this removing may occur after your script execution.
The variables are not merged by JavaScript but directly by PHP in the function "onEditPageImportFormData" of ProofreadPage.body.php and I don't think there is a bug at this level because all Wikisources would be affected.
So, I think that the bug is maybe caused by: - A script that make the initialization of textboxes fail (by example by changing main textbox content before execution of ProofreadPage). - A script that make the fields empty on submitting. - ... Tpt
Date: Sat, 10 Nov 2012 17:09:04 +0100 From: alex.brollo@gmail.com To: wikisource-l@lists.wikimedia.org Subject: [Wikisource-l] Proofreading bug: Change not allowed
When proofreading pages in it.wikisource, we are plagued by this message: Change not allowed - You are not allowed to change the proofreading status of this page
Going back to failed page, we noted that: 1. quality level is reverted to 1;2. anything stored into header has been lost; 3. proofreadpage_username is set to an empty string
The bug is impredictable, it occurs with different frequencies to different users when trying to edit different pages. Something wrong seems to occur when building the page code merging variables, header, body and footer contents. We wrote an "emergency fixing script" but it can only be called after the edit turns out to be wrong.
Is something similar happening into any other wikisource project? Can you give us a link to understand what's happening? And - where can we find the js script which merges variables-header-body-footer into page code to send it to the server?
Alex
_______________________________________________ Wikisource-l mailing list Wikisource-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikisource-l
Thanks Thomas. I'll try to review any it.wikisource specific routine linked to upload event into nsPage. The bug - more or less - is some weeks old, and it seems linked to changes into proofread page extension. We already fixed some bugs springing out from changes in Index form names, but this bug is really very hard, since it is unpredictable, "random"; I suspect some very subtle conflict between different scripts.
I'll post your opinion into our Village pump.
I'll try to catch the problem deselecting any gadget, then activating them again one by one.
Alex
2012/11/10 Thomas PT thomaspt@hotmail.fr
Hi! This bug is very strange. Its looks like it append only on italian Wikisource, so I think that one of your common.js script of gadget cause the bug. This bug is impradicable it might be caused by a change of execution order of two script, by example your common.js (or a gadget) and scripts of ProofreadPage.
ProofreadPage init header, footer and quality contents from the content of the main textbox in its JavaScript so you mustn't supposed that the header and footer content is removed from the textbox when you write a script because this removing may occur after your script execution.
The variables are not merged by JavaScript but directly by PHP in the function "onEditPageImportFormData" of ProofreadPage.body.php and I don't think there is a bug at this level because all Wikisources would be affected.
So, I think that the bug is maybe caused by:
- A script that make the initialization of textboxes fail (by example by
changing main textbox content before execution of ProofreadPage).
- A script that make the fields empty on submitting.
- ...
Tpt
Date: Sat, 10 Nov 2012 17:09:04 +0100 From: alex.brollo@gmail.com To: wikisource-l@lists.wikimedia.org Subject: [Wikisource-l] Proofreading bug: Change not allowed
When proofreading pages in it.wikisource, we are plagued by this message:
Change not allowed - You are not allowed to change the proofreading status of this page
Going back to failed page, we noted that:
- quality level is reverted to 1;
- anything stored into header has been lost;
- proofreadpage_username is set to an empty string
The bug is impredictable, it occurs with different frequencies to different users when trying to edit different pages. Something wrong seems to occur when building the page code merging variables, header, body and footer contents. We wrote an "emergency fixing script" but it can only be called after the edit turns out to be wrong.
Is something similar happening into any other wikisource project? Can you give us a link to understand what's happening? And - where can we find the js script which merges variables-header-body-footer into page code to send it to the server?
Alex
_______________________________________________ Wikisource-l mailing list Wikisource-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikisource-l
Wikisource-l mailing list Wikisource-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikisource-l
2012/11/10 Thomas PT thomaspt@hotmail.fr
Hi!
This bug is very strange. Its looks like it append only on italian Wikisource, so I think that one of your common.js script of gadget cause the bug. This bug is impradicable it might be caused by a change of execution order of two script, by example your common.js (or a gadget) and scripts of ProofreadPage.
ProofreadPage init header, footer and quality contents from the content of the main textbox in its JavaScript so you mustn't supposed that the header and footer content is removed from the textbox when you write a script because this removing may occur after your script execution.
The variables are not merged by JavaScript but directly by PHP in the function "onEditPageImportFormData" of ProofreadPage.body.php and I don't think there is a bug at this level because all Wikisources would be affected.
So, I think that the bug is maybe caused by:
- A script that make the initialization of textboxes fail (by example by
changing main textbox content before execution of ProofreadPage).
- A script that make the fields empty on submitting.
- ...
Tpt
Perhaps I found something interesting. Following the content of $("#editform input[name=wpProofreader]") by js console, I saw that normally, when an user different from previous one changes quality level via quality radiobuttons, the content is updated to current user. Sometimes in it.wikisource it doesn't and the bug pops out.
I can't understand precisely why this happens, but I found that forcing update avoids the bug. I'm trying an "emergency repair" while waiting to understand better the whole thing.
I suspect strongly that something wrong occurs from a routine called on submit; I'll submit the trouble to our best geeks (I'm only a "half-geek" :-) ).
Alex
wikisource-l@lists.wikimedia.org